Issue 8681006: Add CHECKs for file descriptors used in select() by InotifyReaderTask

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8681006: Add CHECKs for file descriptors used in select() by InotifyReaderTask (Closed)

Created:
9 years, 1 month ago by Mattias Nissler (ping if slow)

Modified:
9 years, 1 month ago

Reviewers:
dmac, inferno

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add CHECKs for file descriptors used in select() by InotifyReaderTask Since these are used in an fd_set, there's the possibility that invalid file descriptors cause stack overflow/corruption. BUG=chromium:105162 TEST=No functional changes, compiles and passes tests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111369

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	base/files/file_path_watcher_linux.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mnissler@chromium.org/8681006/1

9 years, 1 month ago (2011-11-23 15:41:32 UTC) #3

Change committed as 111369

Expand Messages | Collapse Messages