Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 868053003: Expose ServiceWorkerRegistration.showNotification() in Service Workers. (Closed)

Created:
5 years, 11 months ago by Peter Beverloo
Modified:
5 years, 10 months ago
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Expose ServiceWorkerRegistration.showNotification() in Service Workers. This makes it possible to display Notifications from within a Service Worker. Layout tests have been added to verify correct behavior. BUG=432527 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189270

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+300 lines, -234 lines) Patch
D LayoutTests/http/tests/notifications/resources/click-close-service-worker.js View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/http/tests/notifications/resources/click-forward-service-worker.js View 1 chunk +0 lines, -11 lines 0 comments Download
A LayoutTests/http/tests/notifications/resources/instrumentation-service-worker.js View 1 1 chunk +45 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/notifications/resources/test-helpers.js View 1 1 chunk +30 lines, -1 line 0 comments Download
D LayoutTests/http/tests/notifications/service-worker-show-notification-click.html View 1 chunk +0 lines, -59 lines 0 comments Download
D LayoutTests/http/tests/notifications/service-worker-show-notification-close.html View 1 chunk +0 lines, -64 lines 0 comments Download
D LayoutTests/http/tests/notifications/service-worker-show-notification-no-permission.html View 1 chunk +0 lines, -42 lines 0 comments Download
D LayoutTests/http/tests/notifications/service-worker-show-notification-not-activated.html View 1 chunk +0 lines, -39 lines 0 comments Download
A LayoutTests/http/tests/notifications/serviceworkerregistration-document-click.html View 1 1 chunk +53 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/notifications/serviceworkerregistration-document-close.html View 1 1 chunk +57 lines, -0 lines 0 comments Download
A + LayoutTests/http/tests/notifications/serviceworkerregistration-document-no-permission.html View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + LayoutTests/http/tests/notifications/serviceworkerregistration-document-not-activated.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
A LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-click.html View 1 2 1 chunk +60 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-no-permission.html View 1 1 chunk +49 lines, -0 lines 0 comments Download
M Source/modules/notifications/ServiceWorkerRegistrationNotifications.idl View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Peter Beverloo
+mvanouwerkerk FYI Blocked on ServiceWorkerGlobalScope.registration not being NULL.
5 years, 11 months ago (2015-01-23 16:13:10 UTC) #2
Michael van Ouwerkerk
https://codereview.chromium.org/868053003/diff/1/LayoutTests/http/tests/notifications/resources/instrumentation-service-worker.js File LayoutTests/http/tests/notifications/resources/instrumentation-service-worker.js (right): https://codereview.chromium.org/868053003/diff/1/LayoutTests/http/tests/notifications/resources/instrumentation-service-worker.js#newcode43 LayoutTests/http/tests/notifications/resources/instrumentation-service-worker.js:43: if (event.notification.body.indexOf('ACTION:CLOSE') !== false) The return value of indexOf ...
5 years, 10 months ago (2015-01-26 16:52:37 UTC) #3
Peter Beverloo
https://codereview.chromium.org/868053003/diff/1/LayoutTests/http/tests/notifications/resources/instrumentation-service-worker.js File LayoutTests/http/tests/notifications/resources/instrumentation-service-worker.js (right): https://codereview.chromium.org/868053003/diff/1/LayoutTests/http/tests/notifications/resources/instrumentation-service-worker.js#newcode43 LayoutTests/http/tests/notifications/resources/instrumentation-service-worker.js:43: if (event.notification.body.indexOf('ACTION:CLOSE') !== false) On 2015/01/26 16:52:37, Michael van ...
5 years, 10 months ago (2015-01-27 11:16:56 UTC) #4
Michael van Ouwerkerk
lgtm
5 years, 10 months ago (2015-01-27 11:25:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868053003/40001
5 years, 10 months ago (2015-01-30 16:44:41 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 18:26:06 UTC) #8
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189270

Powered by Google App Engine
This is Rietveld 408576698