LayoutTests/http/tests/notifications/serviceworkerregistration-document-not-activated.html - Issue 868053003: Expose ServiceWorkerRegistration.showNotification() in Service Workers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/notifications/serviceworkerregistration-document-not-activated.html

Issue 868053003: Expose ServiceWorkerRegistration.showNotification() in Service Workers. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/notifications/serviceworkerregistration-document-no-permission.html ('k') | LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-click.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/notifications/serviceworkerregistration-document-not-activated.html

diff --git a/LayoutTests/http/tests/notifications/service-worker-show-notification-not-activated.html b/LayoutTests/http/tests/notifications/serviceworkerregistration-document-not-activated.html

similarity index 95%

rename from LayoutTests/http/tests/notifications/service-worker-show-notification-not-activated.html

rename to LayoutTests/http/tests/notifications/serviceworkerregistration-document-not-activated.html

index 544560ed8b049dbc0f329dea6af18520fcc4af4b..cc6396b00ec84a39fa566dca9da21c73ca0da92f 100644

--- a/LayoutTests/http/tests/notifications/service-worker-show-notification-not-activated.html

+++ b/LayoutTests/http/tests/notifications/serviceworkerregistration-document-not-activated.html

@@ -10,14 +10,14 @@

// Tests that the showNotification() function rejects the returned promise with a

// TypeError when the Service Worker is not activated yet.

- async_test(function (test) {

+ async_test(function(test) {

var scope = 'resources/scope/service-worker-show-notification-not-activated',

workerUrl = 'resources/empty-worker.js';

if (window.testRunner)

testRunner.grantWebNotificationPermission(location.origin, false);

- service_worker_unregister_and_register(test, workerUrl, scope).then(function (registration) {

+ service_worker_unregister_and_register(test, workerUrl, scope).then(function(registration) {

assert_inherits(registration, 'showNotification', 'showNotification() must be exposed.');

registration.showNotification('Title', {

body: 'Hello, world!',