Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Unified Diff: sky/engine/bindings/templates/interface.cpp

Issue 867903002: Remove UseCounter (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/bindings/templates/attributes.cpp ('k') | sky/engine/bindings/templates/methods.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/bindings/templates/interface.cpp
diff --git a/sky/engine/bindings/templates/interface.cpp b/sky/engine/bindings/templates/interface.cpp
index 288a3ad204491a43e5c90935019ca20ba0d2a9c1..bc533f7d4490957e5b94b40b0d82e41ced006378 100644
--- a/sky/engine/bindings/templates/interface.cpp
+++ b/sky/engine/bindings/templates/interface.cpp
@@ -725,17 +725,8 @@ bool initialize{{cpp_class}}({{cpp_class}}Init& eventInit, const Dictionary& opt
if (attribute.is_initialized_by_event_constructor and
not attribute.idl_type == 'any')%}
{% set is_nullable = 'true' if attribute.is_nullable else 'false' %}
- {% if attribute.deprecate_as %}
- if (DictionaryHelper::convert(options, conversionContext.setConversionType("{{attribute.idl_type}}", {{is_nullable}}), "{{attribute.name}}", eventInit.{{attribute.cpp_name}})) {
- if (options.hasProperty("{{attribute.name}}"))
- UseCounter::countDeprecation(callingExecutionContext(info.GetIsolate()), UseCounter::{{attribute.deprecate_as}});
- } else {
- return false;
- }
- {% else %}
if (!DictionaryHelper::convert(options, conversionContext.setConversionType("{{attribute.idl_type}}", {{is_nullable}}), "{{attribute.name}}", eventInit.{{attribute.cpp_name}}))
return false;
- {% endif %}
{% endfor %}
return true;
}
@@ -750,9 +741,6 @@ bool initialize{{cpp_class}}({{cpp_class}}Init& eventInit, const Dictionary& opt
void {{v8_class}}::constructorCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
{
TRACE_EVENT_SCOPED_SAMPLING_STATE("blink", "DOMConstructor");
- {% if measure_as %}
- UseCounter::count(callingExecutionContext(info.GetIsolate()), UseCounter::{{measure_as}});
- {% endif %}
if (!info.IsConstructCall()) {
V8ThrowException::throwTypeError(ExceptionMessages::constructorNotCallableAsFunction("{{interface_name}}"), info.GetIsolate());
return;
« no previous file with comments | « sky/engine/bindings/templates/attributes.cpp ('k') | sky/engine/bindings/templates/methods.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698