Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Unified Diff: sky/engine/bindings/templates/methods.cpp

Issue 867903002: Remove UseCounter (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/bindings/templates/interface.cpp ('k') | sky/engine/core/animation/Animation.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/bindings/templates/methods.cpp
diff --git a/sky/engine/bindings/templates/methods.cpp b/sky/engine/bindings/templates/methods.cpp
index f4e214d99f32653695f3bfb0e2f6281b931f303d..c22ff0840fec746335e5ad2d4afffb9f99e0c23b 100644
--- a/sky/engine/bindings/templates/methods.cpp
+++ b/sky/engine/bindings/templates/methods.cpp
@@ -383,12 +383,6 @@ we must ensure either ALL or NO methods in this overload return Promise #}
static void {{overloads.name}}Method{{world_suffix}}(const v8::FunctionCallbackInfo<v8::Value>& info)
{
ExceptionState exceptionState(ExceptionState::ExecutionContext, "{{overloads.name}}", "{{interface_name}}", info.Holder(), info.GetIsolate());
- {% if overloads.measure_all_as %}
- UseCounter::count(callingExecutionContext(info.GetIsolate()), UseCounter::{{overloads.measure_all_as}});
- {% endif %}
- {% if overloads.deprecate_all_as %}
- UseCounter::countDeprecation(callingExecutionContext(info.GetIsolate()), UseCounter::{{overloads.deprecate_all_as}});
- {% endif %}
{# First resolve by length #}
{# 2. Initialize argcount to be min(maxarg, n). #}
switch (std::min({{overloads.maxarg}}, info.Length())) {
@@ -401,12 +395,6 @@ static void {{overloads.name}}Method{{world_suffix}}(const v8::FunctionCallbackI
{% filter runtime_enabled(not overloads.runtime_enabled_function_all and
method.runtime_enabled_function) %}
if ({{test}}) {
- {% if method.measure_as and not overloads.measure_all_as %}
- UseCounter::count(callingExecutionContext(info.GetIsolate()), UseCounter::{{method.measure_as}});
- {% endif %}
- {% if method.deprecate_as and not overloads.deprecate_all_as %}
- UseCounter::countDeprecation(callingExecutionContext(info.GetIsolate()), UseCounter::{{method.deprecate_as}});
- {% endif %}
{{method.name}}{{method.overload_index}}Method{{world_suffix}}(info);
return;
}
@@ -443,12 +431,6 @@ static void {{method.name}}MethodCallback{{world_suffix}}(const v8::FunctionCall
{
TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMMethod");
{% if not method.overloads %}{# Overloaded methods are measured in overload_resolution_method() #}
- {% if method.measure_as %}
- UseCounter::count(callingExecutionContext(info.GetIsolate()), UseCounter::{{method.measure_as}});
- {% endif %}
- {% if method.deprecate_as %}
- UseCounter::countDeprecation(callingExecutionContext(info.GetIsolate()), UseCounter::{{method.deprecate_as}});
- {% endif %}
{% endif %}{# not method.overloads #}
{% if method.is_custom %}
{{v8_class}}::{{method.name}}MethodCustom(info);
« no previous file with comments | « sky/engine/bindings/templates/interface.cpp ('k') | sky/engine/core/animation/Animation.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698