Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 867713003: Fix run-time ARMv6 detection. (Closed)

Created:
5 years, 11 months ago by bnoordhuis
Modified:
5 years, 11 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Visibility:
Public.

Description

Fix run-time ARMv6 detection. BUG=v8:3844 LOG=y R=bmeurer@chromium.org Committed: https://crrev.com/9e99a6048a651e8b780c713b0684f813cd74db34 Patch from Ben Noordhuis <info@bnoordhuis.nl>;. Cr-Commit-Position: refs/heads/master@{#26234}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M src/base/cpu.cc View 2 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
bnoordhuis
See https://github.com/iojs/io.js/issues/283 for background. Can this be back-ported to the 4.1 branch, please? Should apply ...
5 years, 11 months ago (2015-01-22 20:48:17 UTC) #2
Benedikt Meurer
lgtm
5 years, 11 months ago (2015-01-23 05:55:44 UTC) #4
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
5 years, 11 months ago (2015-01-23 05:58:26 UTC) #6
Benedikt Meurer
Committed patchset #1 (id:1) manually as 9e99a6048a651e8b780c713b0684f813cd74db34 (presubmit successful).
5 years, 11 months ago (2015-01-23 06:01:04 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 06:01:07 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9e99a6048a651e8b780c713b0684f813cd74db34
Cr-Commit-Position: refs/heads/master@{#26234}

Powered by Google App Engine
This is Rietveld 408576698