Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(46)

Issue 867553003: GPUChannelHost should be cleared before shutting down Blink (Closed)

Created:
4 years, 3 months ago by haraken
Modified:
3 years, 2 months ago
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GPUChannelHost should be cleared before shutting down Blink GPUChannelHost is referenced by gpu_va_context_provider_, media_thread_ and compositor_thread_. Thus we need to clear all of them before RenderThreadImpl::shutdown() shuts down Blink. BUG=451456

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M content/renderer/render_thread_impl.cc View 1 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
haraken
Actually I cannot reproduce the crash and I cannot confirm if this fixes the crash. ...
4 years, 3 months ago (2015-01-26 08:08:18 UTC) #2
haraken
4 years, 3 months ago (2015-01-26 08:10:14 UTC) #4
chamalsl
I can reproduce the crash after fix. I think fix handles the bug in gpu_va_context_provider_. ...
4 years, 3 months ago (2015-01-26 14:39:36 UTC) #5
piman
4 years, 3 months ago (2015-01-27 21:33:26 UTC) #6
LGTM fwiw

Powered by Google App Engine
This is Rietveld 408576698