Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 867523002: Revert of Revert of Isolate courgette_unittests (Closed)

Created:
5 years, 11 months ago by kochi
Modified:
5 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of Isolate courgette_unittests (patchset #1 id:1 of https://codereview.chromium.org/865133002/) Reason for revert: The revert might have been wrong: reverting the revert again. BUG=450912 Original issue's description: > Revert of Isolate courgette_unittests (patchset #1 id:1 of https://codereview.chromium.org/868433002/) > > Reason for revert: > http://crbug.com/450912 > > courget_unittests is failing on Win7(dbg) bots since build#34639. > http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/34639 > > Original issue's description: > > Isolate courgette_unittests > > > > Adding link to http://www.chromium.org/developers/testing/isolated-testing/for-swes for my future self. > > > > R=maruel@chromium.org,jochen@chromium.org > > TBR=jam@chromium.org > > BUG=98637 > > > > Committed: https://crrev.com/c9bd3b9a5667a36c05592ec9d16533be91b4567c > > Cr-Commit-Position: refs/heads/master@{#312531} > > TBR=jam@chromium.org,jochen@chromium.org,maruel@chromium.org,scottmg@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=98637 > > Committed: https://crrev.com/1bdeeeb5eae42e95f82806da9351d77a05403e67 > Cr-Commit-Position: refs/heads/master@{#312571} TBR=jam@chromium.org,jochen@chromium.org,maruel@chromium.org,scottmg@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=98637 Committed: https://crrev.com/217c53ca8128370c64a5d1a4ba15cb4cea5564ac Cr-Commit-Position: refs/heads/master@{#312577}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -13 lines) Patch
M courgette/courgette.gyp View 1 chunk +17 lines, -0 lines 0 comments Download
A courgette/courgette_unittests.isolate View 1 chunk +14 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 8 chunks +48 lines, -8 lines 0 comments Download
M testing/buildbot/chromium.win.json View 5 chunks +30 lines, -5 lines 0 comments Download
M testing/buildbot/chromium_trybot.json View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kochi
Created Revert of Revert of Isolate courgette_unittests
5 years, 11 months ago (2015-01-22 07:19:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/867523002/1
5 years, 11 months ago (2015-01-22 07:19:54 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-22 07:20:48 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/217c53ca8128370c64a5d1a4ba15cb4cea5564ac Cr-Commit-Position: refs/heads/master@{#312577}
5 years, 11 months ago (2015-01-22 07:21:35 UTC) #4
kochi
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/800333003/ by kochi@chromium.org. ...
5 years, 11 months ago (2015-01-22 08:02:00 UTC) #5
scottmg
5 years, 11 months ago (2015-01-22 18:02:39 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698