Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 867493003: bookmarks: Reuse kJavaScriptScheme constant from //url module. (Closed)

Created:
5 years, 10 months ago by tfarina
Modified:
5 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, noyau+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bookmarks: Reuse kJavaScriptScheme constant from //url module. BUG=None TEST=no functional changes R=sky@chromium.org Committed: https://crrev.com/dfadfaf7aa9581813fc67b283ff77ad0eceb3c61 Cr-Commit-Position: refs/heads/master@{#315194}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -7 lines) Patch
M components/bookmarks/browser/bookmark_node_data_views.cc View 2 chunks +2 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
tfarina
5 years, 10 months ago (2015-02-05 15:43:41 UTC) #1
sky
LGTM
5 years, 10 months ago (2015-02-05 18:00:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/867493003/1
5 years, 10 months ago (2015-02-07 12:07:35 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-07 12:30:59 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-07 12:32:51 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dfadfaf7aa9581813fc67b283ff77ad0eceb3c61
Cr-Commit-Position: refs/heads/master@{#315194}

Powered by Google App Engine
This is Rietveld 408576698