Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Unified Diff: components/bookmarks/browser/bookmark_node_data_views.cc

Issue 867493003: bookmarks: Reuse kJavaScriptScheme constant from //url module. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/bookmarks/browser/bookmark_node_data_views.cc
diff --git a/components/bookmarks/browser/bookmark_node_data_views.cc b/components/bookmarks/browser/bookmark_node_data_views.cc
index 136d80efe2927c6d7db3949c551c7e3e6a4e551e..64cd1f6000419d9eaff09cb410770f11e04d5db7 100644
--- a/components/bookmarks/browser/bookmark_node_data_views.cc
+++ b/components/bookmarks/browser/bookmark_node_data_views.cc
@@ -8,15 +8,10 @@
#include "base/pickle.h"
#include "base/strings/utf_string_conversions.h"
#include "ui/base/clipboard/clipboard.h"
+#include "url/url_constants.h"
namespace bookmarks {
-namespace {
-
-const char kJavaScriptScheme[] = "javascript";
-
-} // namespace
-
// static
const ui::OSExchangeData::CustomFormat&
BookmarkNodeData::GetBookmarkCustomFormat() {
@@ -35,7 +30,7 @@ void BookmarkNodeData::Write(const base::FilePath& profile_path,
// If there is only one element and it is a URL, write the URL to the
// clipboard.
if (has_single_url()) {
- if (elements[0].url.SchemeIs(kJavaScriptScheme)) {
+ if (elements[0].url.SchemeIs(url::kJavaScriptScheme)) {
data->SetString(base::UTF8ToUTF16(elements[0].url.spec()));
} else {
data->SetURL(elements[0].url, elements[0].title);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698