Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 867463008: NaCl: Update revision in DEPS, 58c9abe -> fea15c4 (Closed)

Created:
5 years, 10 months ago by Mark Seaborn
Modified:
5 years, 10 months ago
Reviewers:
JF
CC:
chromium-reviews, bbudge, Derek Schuff, native-client-reviews_googlegroups.com, pcc, Petr Hosek, shyamsundarr
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NaCl: Update revision in DEPS, 58c9abe -> fea15c4 This pulls in the following Native Client changes: f02226b: (bbudge@chromium.org) Disable mmap_unittest.cc tests on Windows 64 in Debug... 6bc00f6: (dschuff@chromium.org) Update upstream compiler_rt to HEAD and use official git mirror 55d212c: (phosek@chromium.org) Updates the tools Makefile to work with Git ccc9c66: (shyamsundarr@chromium.org) Add all remaining avx2 instructions except vgather. 9595661: (jfb@chromium.org) Enable -Werror for LLVM build aa51c35: (pcc@google.com) Disable -flto when compiling nacl_bootstrap_lib. 476c662: (jfb@chromium.org) PNaCl: Update Subzero and LLVM revision in pnacl/COMPONENT_REVISIONS 2f388a0: (dschuff@chromium.org) Enable SCons testing of arm-nacl-clang on the bots fea15c4: (bbudge@chromium.org) Disable mmap_unittest.cc tests on Windows 64 in Debug... BUG=none TEST=browser_tests and nacl_integration CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_arm_compile,linux_nacl_sdk_build Committed: https://crrev.com/cebaf8cb5f60a5e3f3ecbfd65ebb338c90dba400 Cr-Commit-Position: refs/heads/master@{#314020}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
Mark Seaborn
5 years, 10 months ago (2015-01-30 20:29:16 UTC) #2
JF
lgtm
5 years, 10 months ago (2015-01-30 22:52:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/867463008/1
5 years, 10 months ago (2015-01-30 23:04:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-30 23:08:35 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/cebaf8cb5f60a5e3f3ecbfd65ebb338c90dba400 Cr-Commit-Position: refs/heads/master@{#314020}
5 years, 10 months ago (2015-01-30 23:09:22 UTC) #7
amineer_google
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/889163003/ by amineer@google.com. ...
5 years, 10 months ago (2015-01-31 21:45:58 UTC) #8
JF
5 years, 10 months ago (2015-01-31 22:26:33 UTC) #9
Message was sent while issue was closed.
On 2015/01/31 21:45:58, amineer wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/889163003/ by mailto:amineer@google.com.
> 
> The reason for reverting is: This is causing official builds to fail, as the
> DEPS hash is not valid.

Re-rolled in:
  https://codereview.chromium.org/890173002

Powered by Google App Engine
This is Rietveld 408576698