Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 890173002: NaCl: Update revision in DEPS, 58c9abe -> fea15c4 (Closed)

Created:
5 years, 10 months ago by JF
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NaCl: Update revision in DEPS, 58c9abe -> fea15c4 Redo DEPS roll from: https://codereview.chromium.org/867463008/ Reverted in: https://codereview.chromium.org/889163003/ Because the hash was improperly abbreviated. This roll has the proper hash. I'm mildly troubled that all tests passed. This pulls in the following Native Client changes: f02226b: (bbudge@chromium.org) Disable mmap_unittest.cc tests on Windows 64 in Debug... 6bc00f6: (dschuff@chromium.org) Update upstream compiler_rt to HEAD and use official git mirror 55d212c: (phosek@chromium.org) Updates the tools Makefile to work with Git ccc9c66: (shyamsundarr@chromium.org) Add all remaining avx2 instructions except vgather. 9595661: (jfb@chromium.org) Enable -Werror for LLVM build aa51c35: (pcc@google.com) Disable -flto when compiling nacl_bootstrap_lib. 476c662: (jfb@chromium.org) PNaCl: Update Subzero and LLVM revision in pnacl/COMPONENT_REVISIONS 2f388a0: (dschuff@chromium.org) Enable SCons testing of arm-nacl-clang on the bots fea15c4: (bbudge@chromium.org) Disable mmap_unittest.cc tests on Windows 64 in Debug... BUG=none TEST=browser_tests and nacl_integration CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_arm_compile,linux_nacl_sdk_build R= mseaborn@chromium.org, bradnelson@chromium.org Committed: https://crrev.com/0d141491fc5ee89bb8d48389efd99e677a47110d Cr-Commit-Position: refs/heads/master@{#314077}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
JF
5 years, 10 months ago (2015-01-31 22:25:44 UTC) #1
JF
FWIW the deps bump script caused the issue: https://codereview.chromium.org/872813004/
5 years, 10 months ago (2015-01-31 22:37:17 UTC) #2
Mark Seaborn
LGTM
5 years, 10 months ago (2015-02-01 00:08:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/890173002/1
5 years, 10 months ago (2015-02-01 00:09:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-01 02:11:10 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-01 02:12:07 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0d141491fc5ee89bb8d48389efd99e677a47110d
Cr-Commit-Position: refs/heads/master@{#314077}

Powered by Google App Engine
This is Rietveld 408576698