Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 867453002: MIPS: Use signaling NaN for holes in fixed double arrays. (Closed)

Created:
5 years, 11 months ago by paul.l...
Modified:
5 years, 11 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Use signaling NaN for holes in fixed double arrays. Port 9eace97bbaab72962c0fda62e5f9011a10604d0d Port 5d641ec969e376ee7fa258b41b2988c9e75c4bc8 BUG= Committed: https://crrev.com/3552f87e8f8ede90f6f6a8a9c07f4608c03877f0 Cr-Commit-Position: refs/heads/master@{#26208}

Patch Set 1 #

Patch Set 2 : Fix bogus delay slot usage with new def of kHoleNanUpper32. #

Patch Set 3 : port Benedikt's fix for x87 sNaN corruption in simulator. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -9 lines) Patch
M src/mips/codegen-mips.cc View 1 1 chunk +4 lines, -3 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
M src/mips/lithium-mips.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/codegen-mips64.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-macro-assembler-mips.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
paul.l...
PTAL.
5 years, 11 months ago (2015-01-21 22:28:49 UTC) #2
akos.palfi.imgtec
LGTM
5 years, 11 months ago (2015-01-21 22:36:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/867453002/40001
5 years, 11 months ago (2015-01-22 04:06:23 UTC) #5
paul.l...
add reviewers.
5 years, 11 months ago (2015-01-22 05:53:06 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-22 06:15:01 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-22 06:15:17 UTC) #9
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/3552f87e8f8ede90f6f6a8a9c07f4608c03877f0
Cr-Commit-Position: refs/heads/master@{#26208}

Powered by Google App Engine
This is Rietveld 408576698