src/mips64/macro-assembler-mips64.cc - Issue 867453002: MIPS: Use signaling NaN for holes in fixed double arrays.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/mips64/macro-assembler-mips64.cc

Issue 867453002: MIPS: Use signaling NaN for holes in fixed double arrays. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: port Benedikt's fix for x87 sNaN corruption in simulator. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/mips64/macro-assembler-mips64.cc

diff --git a/src/mips64/macro-assembler-mips64.cc b/src/mips64/macro-assembler-mips64.cc

index 2761ca0f9366786b2bc811192600730ea490ca1a..903247394301f5efff2b8b0489b14d70a2c03ca6 100644

--- a/src/mips64/macro-assembler-mips64.cc

+++ b/src/mips64/macro-assembler-mips64.cc

@@ -3884,7 +3884,7 @@ void MacroAssembler::StoreNumberToDoubleElements(Register value_reg,

// Check for nan: all NaN values have a value greater (signed) than 0x7ff00000

// in the exponent.

- li(scratch1, Operand(kNaNOrInfinityLowerBoundUpper32));

+ li(scratch1, Operand(kHoleNanUpper32 & HeapNumber::kExponentMask));

lw(exponent_reg, FieldMemOperand(value_reg, HeapNumber::kExponentOffset));

Branch(&maybe_nan, ge, exponent_reg, Operand(scratch1));

« no previous file with comments | « src/mips64/codegen-mips64.cc ('k') | test/cctest/test-macro-assembler-mips.cc » ('j') | no next file with comments »