Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 867353002: Revert of Run task queue manager work in batches (Closed)

Created:
5 years, 11 months ago by jam
Modified:
5 years, 11 months ago
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam, scheduler-bugs_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Run task queue manager work in batches (patchset #9 id:160001 of https://codereview.chromium.org/845543004/) Reason for revert: Trying to see if this is the cause of MediaTest.Yuv* failures on Mac: http://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/2373 http://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests/builds/3274 Original issue's description: > Run task queue manager work in batches > > This patch lets the task queue manager run more than one posted task > per invocation. This helps reduce the overhead of yielding to and from > the main message loop and can speed up cases where tasks are posted > very frequently. One example is indexeddb, where some operations such as > index building can result in 2500 posted tasks/s (Nexus 7). > > This patch also adds accounting for the desired run time of the next > pending delayed task. This information is used to break out of a work > batch if a delayed task should be run instead. Doing this avoids adding > extra delay to delayed tasks. > > A potential downside of this change is that it can penalize work that > runs on the message loop without going through the task queue manager. > Based on performance tests[1], almost all tasks on the renderer main > thread are already getting executed by the task queue manager, so I > believe this change shouldn't cause a regression. > > [1] https://docs.google.com/a/chromium.org/spreadsheets/d/1IJZpBabW1pr4fb2T8BlkleHcOvHYrjvmCx_dLesxfMA/edit#gid=1492760051 > > BUG=444764 > > Committed: https://crrev.com/d9684457b5349dfc1cc19e8a2d98a69ba00ed058 > Cr-Commit-Position: refs/heads/master@{#312839} TBR=rmcilroy@chromium.org,alexclarke@chromium.org,picksi@chromium.org,skyostil@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=444764 Committed: https://crrev.com/4ac0f5d78c094e3cdca9f245f999ca37f4eff917 Cr-Commit-Position: refs/heads/master@{#312888}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -185 lines) Patch
M content/renderer/scheduler/renderer_scheduler_impl.h View 4 chunks +3 lines, -6 lines 0 comments Download
M content/renderer/scheduler/renderer_scheduler_impl.cc View 2 chunks +1 line, -10 lines 0 comments Download
M content/renderer/scheduler/renderer_scheduler_impl_unittest.cc View 1 chunk +17 lines, -4 lines 0 comments Download
M content/renderer/scheduler/task_queue_manager.h View 5 chunks +1 line, -21 lines 0 comments Download
M content/renderer/scheduler/task_queue_manager.cc View 10 chunks +12 lines, -67 lines 0 comments Download
M content/renderer/scheduler/task_queue_manager_unittest.cc View 2 chunks +0 lines, -77 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jam
Created Revert of Run task queue manager work in batches
5 years, 11 months ago (2015-01-23 19:00:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/867353002/1
5 years, 11 months ago (2015-01-23 19:01:02 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-23 19:02:36 UTC) #3
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 19:03:47 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4ac0f5d78c094e3cdca9f245f999ca37f4eff917
Cr-Commit-Position: refs/heads/master@{#312888}

Powered by Google App Engine
This is Rietveld 408576698