Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: content/renderer/scheduler/renderer_scheduler_impl.cc

Issue 867353002: Revert of Run task queue manager work in batches (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/scheduler/renderer_scheduler_impl.h" 5 #include "content/renderer/scheduler/renderer_scheduler_impl.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/debug/trace_event.h" 8 #include "base/debug/trace_event.h"
9 #include "base/debug/trace_event_argument.h" 9 #include "base/debug/trace_event_argument.h"
10 #include "base/message_loop/message_loop_proxy.h" 10 #include "base/message_loop/message_loop_proxy.h"
(...skipping 27 matching lines...) Expand all
38 end_idle_period_closure_ = base::Bind(&RendererSchedulerImpl::EndIdlePeriod, 38 end_idle_period_closure_ = base::Bind(&RendererSchedulerImpl::EndIdlePeriod,
39 weak_renderer_scheduler_ptr_); 39 weak_renderer_scheduler_ptr_);
40 idle_task_runner_ = make_scoped_refptr(new SingleThreadIdleTaskRunner( 40 idle_task_runner_ = make_scoped_refptr(new SingleThreadIdleTaskRunner(
41 task_queue_manager_->TaskRunnerForQueue(IDLE_TASK_QUEUE), 41 task_queue_manager_->TaskRunnerForQueue(IDLE_TASK_QUEUE),
42 base::Bind(&RendererSchedulerImpl::CurrentIdleTaskDeadlineCallback, 42 base::Bind(&RendererSchedulerImpl::CurrentIdleTaskDeadlineCallback,
43 weak_renderer_scheduler_ptr_))); 43 weak_renderer_scheduler_ptr_)));
44 renderer_task_queue_selector_->SetQueuePriority( 44 renderer_task_queue_selector_->SetQueuePriority(
45 CONTROL_TASK_QUEUE, RendererTaskQueueSelector::CONTROL_PRIORITY); 45 CONTROL_TASK_QUEUE, RendererTaskQueueSelector::CONTROL_PRIORITY);
46 renderer_task_queue_selector_->DisableQueue(IDLE_TASK_QUEUE); 46 renderer_task_queue_selector_->DisableQueue(IDLE_TASK_QUEUE);
47 task_queue_manager_->SetAutoPump(IDLE_TASK_QUEUE, false); 47 task_queue_manager_->SetAutoPump(IDLE_TASK_QUEUE, false);
48 // See crbug.com/444764 for how this work batch size was derived.
49 task_queue_manager_->SetWorkBatchSize(4);
50 48
51 for (size_t i = 0; i < TASK_QUEUE_COUNT; i++) { 49 for (size_t i = 0; i < TASK_QUEUE_COUNT; i++) {
52 task_queue_manager_->SetQueueName( 50 task_queue_manager_->SetQueueName(
53 i, TaskQueueIdToString(static_cast<QueueId>(i))); 51 i, TaskQueueIdToString(static_cast<QueueId>(i)));
54 } 52 }
55 TRACE_EVENT_OBJECT_CREATED_WITH_ID( 53 TRACE_EVENT_OBJECT_CREATED_WITH_ID(
56 TRACE_DISABLED_BY_DEFAULT("renderer.scheduler"), "RendererScheduler", 54 TRACE_DISABLED_BY_DEFAULT("renderer.scheduler"), "RendererScheduler",
57 this); 55 this);
58 } 56 }
59 57
(...skipping 188 matching lines...) Expand 10 before | Expand all | Expand 10 after
248 task_queue_manager_->PumpQueue(IDLE_TASK_QUEUE); 246 task_queue_manager_->PumpQueue(IDLE_TASK_QUEUE);
249 } 247 }
250 248
251 void RendererSchedulerImpl::EndIdlePeriod() { 249 void RendererSchedulerImpl::EndIdlePeriod() {
252 TRACE_EVENT_ASYNC_END0("renderer.scheduler", 250 TRACE_EVENT_ASYNC_END0("renderer.scheduler",
253 "RendererSchedulerIdlePeriod", this); 251 "RendererSchedulerIdlePeriod", this);
254 main_thread_checker_.CalledOnValidThread(); 252 main_thread_checker_.CalledOnValidThread();
255 renderer_task_queue_selector_->DisableQueue(IDLE_TASK_QUEUE); 253 renderer_task_queue_selector_->DisableQueue(IDLE_TASK_QUEUE);
256 } 254 }
257 255
258 void RendererSchedulerImpl::SetTimeSourceForTesting(
259 scoped_refptr<cc::TestNowSource> time_source) {
260 main_thread_checker_.CalledOnValidThread();
261 time_source_ = time_source;
262 task_queue_manager_->SetTimeSourceForTesting(time_source);
263 }
264
265 base::TimeTicks RendererSchedulerImpl::Now() const { 256 base::TimeTicks RendererSchedulerImpl::Now() const {
266 return UNLIKELY(time_source_) ? time_source_->Now() : base::TimeTicks::Now(); 257 return gfx::FrameTime::Now();
267 } 258 }
268 259
269 RendererSchedulerImpl::PollableNeedsUpdateFlag::PollableNeedsUpdateFlag( 260 RendererSchedulerImpl::PollableNeedsUpdateFlag::PollableNeedsUpdateFlag(
270 base::Lock* write_lock_) 261 base::Lock* write_lock_)
271 : flag_(false), write_lock_(write_lock_) { 262 : flag_(false), write_lock_(write_lock_) {
272 } 263 }
273 264
274 RendererSchedulerImpl::PollableNeedsUpdateFlag::~PollableNeedsUpdateFlag() { 265 RendererSchedulerImpl::PollableNeedsUpdateFlag::~PollableNeedsUpdateFlag() {
275 } 266 }
276 267
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
331 state->SetDouble("last_input_time", 322 state->SetDouble("last_input_time",
332 (last_input_time_ - base::TimeTicks()).InMillisecondsF()); 323 (last_input_time_ - base::TimeTicks()).InMillisecondsF());
333 state->SetDouble( 324 state->SetDouble(
334 "estimated_next_frame_begin", 325 "estimated_next_frame_begin",
335 (estimated_next_frame_begin_ - base::TimeTicks()).InMillisecondsF()); 326 (estimated_next_frame_begin_ - base::TimeTicks()).InMillisecondsF());
336 327
337 return state; 328 return state;
338 } 329 }
339 330
340 } // namespace content 331 } // namespace content
OLDNEW
« no previous file with comments | « content/renderer/scheduler/renderer_scheduler_impl.h ('k') | content/renderer/scheduler/renderer_scheduler_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698