Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Unified Diff: ui/PRESUBMIT.py

Issue 867163003: ui: Add PRESUBMIT script to check the usage of scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixes Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/PRESUBMIT.py
diff --git a/ui/PRESUBMIT.py b/ui/PRESUBMIT.py
new file mode 100644
index 0000000000000000000000000000000000000000..adf2829c3571c27e030295502a828a0f390ff079
--- /dev/null
+++ b/ui/PRESUBMIT.py
@@ -0,0 +1,36 @@
+# Copyright 2015 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+"""Presubmit script for ui.
+
+See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
+for more details about the presubmit API built into depot_tools.
+"""
+
+INCLUDE_CPP_FILES_ONLY = (
+ r'.*\.(h|cc|mm)$',
Marc-Antoine Ruel (Google) 2015/01/30 17:15:41 (cc|h|mm)
tfarina 2015/01/31 00:34:36 Done. Just curious, does this makes any differenc
+)
+
+def CheckScopedPtr(input_api, output_api,
+ white_list=INCLUDE_CPP_FILES_ONLY, black_list=None):
+ black_list = tuple(black_list or input_api.DEFAULT_BLACK_LIST)
+ source_file_filter = lambda x: input_api.FilterSourceFile(x,
+ white_list,
+ black_list)
+ errors = []
+ for f in input_api.AffectedSourceFiles(source_file_filter):
+ for line_number, line in f.ChangedContents():
+ # Disallow:
+ # scoped_ptr<T>()
+ if re.search(r'\bscoped_ptr<.*?>\(\)', line):
+ errors.append(output_api.PresubmitError(
+ '%s:%d uses scoped_ptr<T>(). Use nullptr instead.' %
+ (f.LocalPath(), line_number)))
+ return errors
+
+
+def CheckChangeOnUpload(input_api, output_api):
Marc-Antoine Ruel (Google) 2015/01/30 17:15:42 Only on upload?
tfarina 2015/01/31 00:34:36 Done. I think it won't hurt, right?
+ results = []
+ results += CheckScopedPtr(input_api, output_api)
+ return results
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698