OLD | NEW |
---|---|
(Empty) | |
1 # Copyright 2015 The Chromium Authors. All rights reserved. | |
2 # Use of this source code is governed by a BSD-style license that can be | |
3 # found in the LICENSE file. | |
4 | |
5 """Presubmit script for ui. | |
6 | |
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts | |
8 for more details about the presubmit API built into depot_tools. | |
9 """ | |
10 | |
11 INCLUDE_CPP_FILES_ONLY = ( | |
12 r'.*\.(h|cc|mm)$', | |
Marc-Antoine Ruel (Google)
2015/01/30 17:15:41
(cc|h|mm)
tfarina
2015/01/31 00:34:36
Done.
Just curious, does this makes any differenc
| |
13 ) | |
14 | |
15 def CheckScopedPtr(input_api, output_api, | |
16 white_list=INCLUDE_CPP_FILES_ONLY, black_list=None): | |
17 black_list = tuple(black_list or input_api.DEFAULT_BLACK_LIST) | |
18 source_file_filter = lambda x: input_api.FilterSourceFile(x, | |
19 white_list, | |
20 black_list) | |
21 errors = [] | |
22 for f in input_api.AffectedSourceFiles(source_file_filter): | |
23 for line_number, line in f.ChangedContents(): | |
24 # Disallow: | |
25 # scoped_ptr<T>() | |
26 if re.search(r'\bscoped_ptr<.*?>\(\)', line): | |
27 errors.append(output_api.PresubmitError( | |
28 '%s:%d uses scoped_ptr<T>(). Use nullptr instead.' % | |
29 (f.LocalPath(), line_number))) | |
30 return errors | |
31 | |
32 | |
33 def CheckChangeOnUpload(input_api, output_api): | |
Marc-Antoine Ruel (Google)
2015/01/30 17:15:42
Only on upload?
tfarina
2015/01/31 00:34:36
Done.
I think it won't hurt, right?
| |
34 results = [] | |
35 results += CheckScopedPtr(input_api, output_api) | |
36 return results | |
OLD | NEW |