ui: Add PRESUBMIT script to check the usage of scoped_ptr.

ui: Add PRESUBMIT script to check the usage of scoped_ptr.

This script should check the usage of scoped_ptr in files changed in the
change list when uploading to codereview.chromium.org. That way we
should avoid future regressions.

BUG=None
TEST=git cl presubmit -uv
R=sky@chromium.org

Committed: https://crrev.com/a852d632b1169f5c49c88803d4690f663a67ea4e
Cr-Commit-Position: refs/heads/master@{#314091}

[tfarina, 2015-01-29 04:29:03]

Continuation of https://codereview.chromium.org/855023003/

[sky, 2015-01-29 14:28:20]

I'm not particularly familiar with presubmit checks. Can you add another
reviewer that is?

https://codereview.chromium.org/867163003/diff/1/ui/PRESUBMIT.py
File ui/PRESUBMIT.py (right):

https://codereview.chromium.org/867163003/diff/1/ui/PRESUBMIT.py#newcode1
ui/PRESUBMIT.py:1: # Copyright (c) 2012 The Chromium Authors. All rights
reserved.
2015 and no copyright.

https://codereview.chromium.org/867163003/diff/1/ui/PRESUBMIT.py#newcode12
ui/PRESUBMIT.py:12: r'.*\.(cc|h)$',
What about .mm files?

[tfarina, 2015-01-30 14:06:36]

tfarina@chromium.org changed reviewers:
+ maruel@chromium.org

[tfarina, 2015-01-30 14:07:11]

Marc-Antoine, could you review this change?

https://codereview.chromium.org/867163003/diff/1/ui/PRESUBMIT.py
File ui/PRESUBMIT.py (right):

https://codereview.chromium.org/867163003/diff/1/ui/PRESUBMIT.py#newcode1
ui/PRESUBMIT.py:1: # Copyright (c) 2012 The Chromium Authors. All rights
reserved.
On 2015/01/29 14:28:20, sky wrote:
> 2015 and no copyright.

Done.

https://codereview.chromium.org/867163003/diff/1/ui/PRESUBMIT.py#newcode12
ui/PRESUBMIT.py:12: r'.*\.(cc|h)$',
On 2015/01/29 14:28:20, sky wrote:
> What about .mm files?

Done.

[Marc-Antoine Ruel (Google), 2015-01-30 17:15:41]

maruel@google.com changed reviewers:
+ maruel@google.com

[Marc-Antoine Ruel (Google), 2015-01-30 17:15:42]

rubberstamp lgtm

https://codereview.chromium.org/867163003/diff/20001/ui/PRESUBMIT.py
File ui/PRESUBMIT.py (right):

https://codereview.chromium.org/867163003/diff/20001/ui/PRESUBMIT.py#newcode12
ui/PRESUBMIT.py:12: r'.*\.(h|cc|mm)$',
(cc|h|mm)

https://codereview.chromium.org/867163003/diff/20001/ui/PRESUBMIT.py#newcode33
ui/PRESUBMIT.py:33: def CheckChangeOnUpload(input_api, output_api):
Only on upload?

[sky, 2015-01-30 19:09:52]

LGTM

[tfarina, 2015-01-31 00:34:36]

https://codereview.chromium.org/867163003/diff/20001/ui/PRESUBMIT.py
File ui/PRESUBMIT.py (right):

https://codereview.chromium.org/867163003/diff/20001/ui/PRESUBMIT.py#newcode12
ui/PRESUBMIT.py:12: r'.*\.(h|cc|mm)$',
On 2015/01/30 17:15:41, Marc-Antoine Ruel (Google) wrote:
> (cc|h|mm)

Done.

Just curious, does this makes any difference? I followed the way we do in
build/filename_rules.gypi

https://codereview.chromium.org/867163003/diff/20001/ui/PRESUBMIT.py#newcode33
ui/PRESUBMIT.py:33: def CheckChangeOnUpload(input_api, output_api):
On 2015/01/30 17:15:42, Marc-Antoine Ruel (Google) wrote:
> Only on upload?

Done.

I think it won't hurt, right?

[tfarina, 2015-02-01 10:14:57]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2015-02-01 10:16:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/867163003/40001

[commit-bot: I haz the power, 2015-02-01 17:38:53]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-01 17:39:36]

Patchset 3 (id:??) landed as
https://crrev.com/a852d632b1169f5c49c88803d4690f663a67ea4e
Cr-Commit-Position: refs/heads/master@{#314091}

[Daniel Erat, 2015-02-02 03:19:57]

On 2015/02/01 17:39:36, I haz the power (commit-bot) wrote:
> Patchset 3 (id:??) landed as
> https://crrev.com/a852d632b1169f5c49c88803d4690f663a67ea4e
> Cr-Commit-Position: refs/heads/master@{#314091}

this seems broken:

Traceback (most recent call last):
  File "/usr/local/google/home/derat/local/depot_tools/git_cl.py", line 2983, in
<module>
    sys.exit(main(sys.argv[1:]))
  File "/usr/local/google/home/derat/local/depot_tools/git_cl.py", line 2969, in
main
    return dispatcher.execute(OptionParser(), argv)
  File "/usr/local/google/home/derat/local/depot_tools/subcommand.py", line 245,
in execute
    return command(parser, args[1:])
  File "/usr/local/google/home/derat/local/depot_tools/git_cl.py", line 1943, in
CMDupload
    change=change)
  File "/usr/local/google/home/derat/local/depot_tools/git_cl.py", line 936, in
RunHook
    rietveld_obj=self.RpcServer())
  File "/usr/local/google/home/derat/local/depot_tools/presubmit_support.py",
line 1396, in DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File "/usr/local/google/home/derat/local/depot_tools/presubmit_support.py",
line 1313, in ExecPresubmitScript
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "<string>", line 40, in CheckChangeOnUpload
  File "<string>", line 35, in CheckChange
  File "<string>", line 26, in CheckScopedPtr
NameError: global name 're' is not defined

---

i think you need to import 're'.

[M-A Ruel, 2015-02-02 03:21:47]

https://codereview.chromium.org/867163003/diff/40001/ui/PRESUBMIT.py
File ui/PRESUBMIT.py (right):

https://codereview.chromium.org/867163003/diff/40001/ui/PRESUBMIT.py#newcode26
ui/PRESUBMIT.py:26: if re.search(r'\bscoped_ptr<.*?>\(\)', line):
input_api.re.search(

[tfarina, 2015-02-02 03:33:01]

https://codereview.chromium.org/867163003/diff/40001/ui/PRESUBMIT.py
File ui/PRESUBMIT.py (right):

https://codereview.chromium.org/867163003/diff/40001/ui/PRESUBMIT.py#newcode26
ui/PRESUBMIT.py:26: if re.search(r'\bscoped_ptr<.*?>\(\)', line):
On 2015/02/02 03:21:47, M-A Ruel wrote:
> input_api.re.search(

Done.