Change Files app's banner controller into a banners UI class.

Change Files app's banner controller into a banners UI class.

It still partly a controller, but it mostly have view logic.

TEST=Tested manually with to show a Drive banner.
BUG=451658
Committed: https://crrev.com/13eb8471addff50b6d55ecd66605097102572e63
Cr-Commit-Position: refs/heads/master@{#313005}

[mtomasz, 2015-01-24 01:45:04]

mtomasz@chromium.org changed reviewers:
+ hirono@chromium.org

[mtomasz, 2015-01-24 01:45:11]

@hirono: PTAL. Thanks.

[hirono, 2015-01-24 01:57:01]

lgtm!

[hirono, 2015-01-24 01:57:05]

lgtm!

[mtomasz, 2015-01-24 01:58:05]

On 2015/01/24 01:57:05, hirono wrote:
> lgtm!

Thanks! Thanks! :)

[mtomasz, 2015-01-24 01:58:20]

The CQ bit was checked by mtomasz@chromium.org

[commit-bot: I haz the power, 2015-01-24 01:59:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/867033003/1

[commit-bot: I haz the power, 2015-01-24 03:49:40]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-01-24 03:50:31]

Patchset 1 (id:??) landed as
https://crrev.com/13eb8471addff50b6d55ecd66605097102572e63
Cr-Commit-Position: refs/heads/master@{#313005}

[Steve McKay, 2015-01-26 18:15:27]

smckay@chromium.org changed reviewers:
+ smckay@chromium.org

[Steve McKay, 2015-01-26 18:15:28]

Looks like this broke JS-compilation.

~/srcs/chromium/src $ famcomp-fg 
ninja: Entering directory `out/Default'
ninja: error:
'../../ui/file_manager/file_manager/foreground/js/ui/drive_banners.js', needed
by 'gen/closure/ui/file_manager/file_manager/foreground/js/main.js', missing and
no known rule to make it

[mtomasz, 2015-01-26 18:23:30]

On 2015/01/26 18:15:28, Steve McKay wrote:
> Looks like this broke JS-compilation.
> 
> ~/srcs/chromium/src $ famcomp-fg 
> ninja: Entering directory `out/Default'
> ninja: error:
> '../../ui/file_manager/file_manager/foreground/js/ui/drive_banners.js', needed
> by 'gen/closure/ui/file_manager/file_manager/foreground/js/main.js', missing
and
> no known rule to make it

Could you provide your famcomp-fg alias?

[mtomasz, 2015-01-26 18:30:37]

On 2015/01/26 18:23:30, mtomasz wrote:
> On 2015/01/26 18:15:28, Steve McKay wrote:
> > Looks like this broke JS-compilation.
> > 
> > ~/srcs/chromium/src $ famcomp-fg 
> > ninja: Entering directory `out/Default'
> > ninja: error:
> > '../../ui/file_manager/file_manager/foreground/js/ui/drive_banners.js',
needed
> > by 'gen/closure/ui/file_manager/file_manager/foreground/js/main.js', missing
> and
> > no known rule to make it
> 
> Could you provide your famcomp-fg alias?

$ git grep drive_banners
0 results.

I guess you have an old make file. Could you try build/gyp_chromium &&
famcomp-fg?

[chromium-reviews, 2015-01-26 18:38:13]

Ah. Yeah. User error. My jscomp alias was pointing to a different out
directory.

On Mon, Jan 26, 2015 at 10:30 AM, <mtomasz@chromium.org> wrote:

> On 2015/01/26 18:23:30, mtomasz wrote:
>
>> On 2015/01/26 18:15:28, Steve McKay wrote:
>> > Looks like this broke JS-compilation.
>> >
>> > ~/srcs/chromium/src $ famcomp-fg
>> > ninja: Entering directory `out/Default'
>> > ninja: error:
>> > '../../ui/file_manager/file_manager/foreground/js/ui/drive_banners.js',
>>
> needed
>
>> > by 'gen/closure/ui/file_manager/file_manager/foreground/js/main.js',
>> missing
>> and
>> > no known rule to make it
>>
>
>  Could you provide your famcomp-fg alias?
>>
>
> $ git grep drive_banners
> 0 results.
>
> I guess you have an old make file. Could you try build/gyp_chromium &&
> famcomp-fg?
>
> https://codereview.chromium.org/867033003/
>



-- 
Steve McKay | Eng. | smckay@google.com | 310-359-8331

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.