Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: ui/file_manager/file_manager/foreground/js/file_manager.js

Issue 867033003: Change Files app's banner controller into a banners UI class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/file_manager/file_manager/foreground/js/file_manager.js
diff --git a/ui/file_manager/file_manager/foreground/js/file_manager.js b/ui/file_manager/file_manager/foreground/js/file_manager.js
index 4fc8717f2bcc1b17e36b6ca11e571f9e48bb177a..47209c736edcd0122dc39beb294e61d1541bef82 100644
--- a/ui/file_manager/file_manager/foreground/js/file_manager.js
+++ b/ui/file_manager/file_manager/foreground/js/file_manager.js
@@ -170,13 +170,6 @@ function FileManager() {
this.spinnerController_ = null;
/**
- * Banners in the file list.
- * @type {FileListBannerController}
- * @private
- */
- this.bannersController_ = null;
-
- /**
* Gear menu controller.
* @type {GearMenuController}
* @private
@@ -389,18 +382,6 @@ FileManager.prototype = /** @struct */ {
var self = this;
- // Get the 'allowRedeemOffers' preference before launching
- // FileListBannerController.
- chrome.fileManagerPrivate.getPreferences(function(pref) {
- self.bannersController_ = new FileListBannerController(
- self.directoryModel_,
- self.volumeManager_,
- self.document_,
- pref.allowRedeemOffers);
- self.bannersController_.addEventListener(
- 'relayout', self.ui_.relayout.bind(self.ui_));
- });
-
var listBeingUpdated = null;
this.directoryModel_.addEventListener('begin-update-files', function() {
self.ui_.listContainer.currentList.startBatchUpdates();
@@ -455,7 +436,16 @@ FileManager.prototype = /** @struct */ {
this.selectionHandler_.onFileSelectionChanged();
this.ui_.listContainer.endBatchUpdates();
- callback();
+ // Get the 'allowRedeemOffers' preference for banners.
+ chrome.fileManagerPrivate.getPreferences(function(pref) {
+ this.ui_.initBanners(
+ new Banners(
+ this.directoryModel_,
+ this.volumeManager_,
+ this.document_,
+ pref.allowRedeemOffers));
+ callback();
+ }.bind(this));
};
/**

Powered by Google App Engine
This is Rietveld 408576698