Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Unified Diff: Source/core/frame/LocalDOMWindow.cpp

Issue 866983004: Allow creating new windows from a notificationclick event in SW. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebase Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/frame/LocalDOMWindow.cpp
diff --git a/Source/core/frame/LocalDOMWindow.cpp b/Source/core/frame/LocalDOMWindow.cpp
index 21ea7a4fd548428bda10d12abae0ed2e024e0215..8585eed748af2e07748ff364a54747713500021c 100644
--- a/Source/core/frame/LocalDOMWindow.cpp
+++ b/Source/core/frame/LocalDOMWindow.cpp
@@ -900,9 +900,9 @@ void LocalDOMWindow::focus(ExecutionContext* context)
ASSERT(context);
- bool allowFocus = context->isWindowFocusAllowed();
+ bool allowFocus = context->isWindowInteractionAllowed();
if (allowFocus) {
- context->consumeWindowFocus();
+ context->consumeWindowInteraction();
} else {
ASSERT(isMainThread());
allowFocus = opener() && (opener() != this) && (toDocument(context)->domWindow() == opener());
« no previous file with comments | « Source/core/dom/ScopedWindowFocusAllowedIndicator.h ('k') | Source/modules/serviceworkers/ServiceWorkerGlobalScope.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698