Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(848)

Unified Diff: Source/core/dom/ScopedWindowFocusAllowedIndicator.h

Issue 866983004: Allow creating new windows from a notificationclick event in SW. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebase Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/dom/ExecutionContext.cpp ('k') | Source/core/frame/LocalDOMWindow.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/ScopedWindowFocusAllowedIndicator.h
diff --git a/Source/core/dom/ScopedWindowFocusAllowedIndicator.h b/Source/core/dom/ScopedWindowFocusAllowedIndicator.h
index c6f9ee31b31ef2942987cccd31db72d40385826c..f4a8743a28d08448a40e48e43bd727821031e631 100644
--- a/Source/core/dom/ScopedWindowFocusAllowedIndicator.h
+++ b/Source/core/dom/ScopedWindowFocusAllowedIndicator.h
@@ -31,13 +31,13 @@ private:
: ContextLifecycleObserver(executionContext)
{
if (executionContext)
- executionContext->allowWindowFocus();
+ executionContext->allowWindowInteraction();
}
void dispose()
{
if (executionContext())
- executionContext()->consumeWindowFocus();
+ executionContext()->consumeWindowInteraction();
}
void trace(Visitor* visitor)
@@ -49,7 +49,7 @@ private:
// In Oilpan, destructors are not allowed to touch other on-heap objects.
// The Observer indirection is needed to keep
// ScopedWindowFocusAllowedIndicator off-heap and thus allows its destructor
- // to call executionContext()->consumeWindowFocus().
+ // to call executionContext()->consumeWindowInteraction().
OwnPtrWillBePersistent<Observer> m_observer;
};
« no previous file with comments | « Source/core/dom/ExecutionContext.cpp ('k') | Source/core/frame/LocalDOMWindow.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698