Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Unified Diff: chrome/browser/sync/test/integration/passwords_helper.h

Issue 866983003: GetLoginsRequest: Use ScopedVector to express ownership of forms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@324291_scopedvector
Patch Set: Second fix of the rebase Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/test/integration/passwords_helper.h
diff --git a/chrome/browser/sync/test/integration/passwords_helper.h b/chrome/browser/sync/test/integration/passwords_helper.h
index 2ce1f7ddd3f895dbe13e28b1819028d94fad9ad6..be31d2c085a0d9de1b7bf4fd758e29d31aa5ba9b 100644
--- a/chrome/browser/sync/test/integration/passwords_helper.h
+++ b/chrome/browser/sync/test/integration/passwords_helper.h
@@ -7,6 +7,7 @@
#include <vector>
+#include "base/memory/scoped_vector.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/sync/profile_sync_service.h"
#include "chrome/browser/sync/test/integration/sync_test.h"
@@ -29,11 +30,10 @@ void AddLogin(password_manager::PasswordStore* store,
void UpdateLogin(password_manager::PasswordStore* store,
const autofill::PasswordForm& form);
-// Searches |store| for all logins matching a fake signon realm used only by
-// LivePasswordsSyncTest and adds the results to |matches|. Note that the
-// caller is responsible for deleting the forms added to |matches|.
-void GetLogins(password_manager::PasswordStore* store,
- std::vector<autofill::PasswordForm>& matches);
+// Returns all logins from |store| matching a fake signon realm used only by
+// PasswordsSyncPerfTest.
+ScopedVector<autofill::PasswordForm> GetLogins(
+ password_manager::PasswordStore* store);
// Removes the login held in |form| from the password store |store|. This
// method blocks until the operation is complete.
@@ -91,7 +91,7 @@ int GetPasswordCount(int index);
int GetVerifierPasswordCount();
// Creates a test password form with a well known fake signon realm used only
-// by LivePasswordsSyncTest based on |index|.
+// by PasswordsSyncPerfTest based on |index|.
autofill::PasswordForm CreateTestPasswordForm(int index);
} // namespace passwords_helper
« no previous file with comments | « chrome/browser/profiles/profile_manager_browsertest.cc ('k') | chrome/browser/sync/test/integration/passwords_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698