chrome/browser/profiles/profile_manager_browsertest.cc - Issue 866983003: GetLoginsRequest: Use ScopedVector to express ownership of forms

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/profiles/profile_manager_browsertest.cc

Issue 866983003: GetLoginsRequest: Use ScopedVector to express ownership of forms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@324291_scopedvector

Patch Set: Second fix of the rebase Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/password_store_x_unittest.cc ('k') | chrome/browser/sync/test/integration/passwords_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/profiles/profile_manager_browsertest.cc

diff --git a/chrome/browser/profiles/profile_manager_browsertest.cc b/chrome/browser/profiles/profile_manager_browsertest.cc

index 59bc567fac548453ff4e25facaa842f76cf1fb34..f07472902f85fa851324cbb7d1a820141d046a84 100644

--- a/chrome/browser/profiles/profile_manager_browsertest.cc

+++ b/chrome/browser/profiles/profile_manager_browsertest.cc

@@ -96,11 +96,10 @@ class PasswordStoreConsumerVerifier :

PasswordStoreConsumerVerifier() : called_(false) {}

void OnGetPasswordStoreResults(

- const std::vector<autofill::PasswordForm*>& results) override {

+ ScopedVector<autofill::PasswordForm> results) override {

EXPECT_FALSE(called_);

called_ = true;

- password_entries_.clear();

- password_entries_.assign(results.begin(), results.end());

+ password_entries_.swap(results);

}

bool IsCalled() const { return called_; }