chrome/browser/password_manager/password_store_x.h - Issue 866983003: GetLoginsRequest: Use ScopedVector to express ownership of forms

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/password_store_x.h

Issue 866983003: GetLoginsRequest: Use ScopedVector to express ownership of forms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@324291_scopedvector

Patch Set: Second fix of the rebase Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/password_store_win_unittest.cc ('k') | chrome/browser/password_manager/password_store_x.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/password_store_x.h

diff --git a/chrome/browser/password_manager/password_store_x.h b/chrome/browser/password_manager/password_store_x.h

index 28fad0686b7a63b2c0e5c5bf04897286c381068b..d863cdacd1124d2b0b240789795d582e59cba5e4 100644

--- a/chrome/browser/password_manager/password_store_x.h

+++ b/chrome/browser/password_manager/password_store_x.h

@@ -94,8 +94,10 @@ class PasswordStoreX : public password_manager::PasswordStoreDefault {

void GetLoginsImpl(const autofill::PasswordForm& form,

AuthorizationPromptPolicy prompt_policy,

const ConsumerCallbackRunner& callback_runner) override;

- void GetAutofillableLoginsImpl(GetLoginsRequest* request) override;

- void GetBlacklistLoginsImpl(GetLoginsRequest* request) override;

+ void GetAutofillableLoginsImpl(

+ scoped_ptr<PasswordStore::GetLoginsRequest> request) override;

+ void GetBlacklistLoginsImpl(

+ scoped_ptr<PasswordStore::GetLoginsRequest> request) override;

bool FillAutofillableLogins(

ScopedVector<autofill::PasswordForm>* forms) override;

bool FillBlacklistLogins(