Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(796)

Side by Side Diff: chrome/browser/password_manager/password_store_x.h

Issue 866983003: GetLoginsRequest: Use ScopedVector to express ownership of forms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@324291_scopedvector
Patch Set: Second fix of the rebase Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_STORE_X_H_ 5 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_STORE_X_H_
6 #define CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_STORE_X_H_ 6 #define CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_STORE_X_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
87 const autofill::PasswordForm& form) override; 87 const autofill::PasswordForm& form) override;
88 password_manager::PasswordStoreChangeList RemoveLoginsCreatedBetweenImpl( 88 password_manager::PasswordStoreChangeList RemoveLoginsCreatedBetweenImpl(
89 base::Time delete_begin, 89 base::Time delete_begin,
90 base::Time delete_end) override; 90 base::Time delete_end) override;
91 password_manager::PasswordStoreChangeList RemoveLoginsSyncedBetweenImpl( 91 password_manager::PasswordStoreChangeList RemoveLoginsSyncedBetweenImpl(
92 base::Time delete_begin, 92 base::Time delete_begin,
93 base::Time delete_end) override; 93 base::Time delete_end) override;
94 void GetLoginsImpl(const autofill::PasswordForm& form, 94 void GetLoginsImpl(const autofill::PasswordForm& form,
95 AuthorizationPromptPolicy prompt_policy, 95 AuthorizationPromptPolicy prompt_policy,
96 const ConsumerCallbackRunner& callback_runner) override; 96 const ConsumerCallbackRunner& callback_runner) override;
97 void GetAutofillableLoginsImpl(GetLoginsRequest* request) override; 97 void GetAutofillableLoginsImpl(
98 void GetBlacklistLoginsImpl(GetLoginsRequest* request) override; 98 scoped_ptr<PasswordStore::GetLoginsRequest> request) override;
99 void GetBlacklistLoginsImpl(
100 scoped_ptr<PasswordStore::GetLoginsRequest> request) override;
99 bool FillAutofillableLogins( 101 bool FillAutofillableLogins(
100 ScopedVector<autofill::PasswordForm>* forms) override; 102 ScopedVector<autofill::PasswordForm>* forms) override;
101 bool FillBlacklistLogins( 103 bool FillBlacklistLogins(
102 ScopedVector<autofill::PasswordForm>* forms) override; 104 ScopedVector<autofill::PasswordForm>* forms) override;
103 105
104 // Sort logins by origin, like the ORDER BY clause in login_database.cc. 106 // Sort logins by origin, like the ORDER BY clause in login_database.cc.
105 void SortLoginsByOrigin(std::vector<autofill::PasswordForm*>* list); 107 void SortLoginsByOrigin(std::vector<autofill::PasswordForm*>* list);
106 108
107 // Check to see whether migration is necessary, and perform it if so. 109 // Check to see whether migration is necessary, and perform it if so.
108 void CheckMigration(); 110 void CheckMigration();
(...skipping 18 matching lines...) Expand all
127 // Whether we should allow falling back to the default store. If there is 129 // Whether we should allow falling back to the default store. If there is
128 // nothing to migrate, then the first attempt to use the native store will 130 // nothing to migrate, then the first attempt to use the native store will
129 // be the first time we try to use it and we should allow falling back. If 131 // be the first time we try to use it and we should allow falling back. If
130 // we have migrated successfully, then we do not allow falling back. 132 // we have migrated successfully, then we do not allow falling back.
131 bool allow_fallback_; 133 bool allow_fallback_;
132 134
133 DISALLOW_COPY_AND_ASSIGN(PasswordStoreX); 135 DISALLOW_COPY_AND_ASSIGN(PasswordStoreX);
134 }; 136 };
135 137
136 #endif // CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_STORE_X_H_ 138 #endif // CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_STORE_X_H_
OLDNEW
« no previous file with comments | « chrome/browser/password_manager/password_store_win_unittest.cc ('k') | chrome/browser/password_manager/password_store_x.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698