Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: components/password_manager/core/browser/password_store_default.cc

Issue 866983003: GetLoginsRequest: Use ScopedVector to express ownership of forms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@324291_scopedvector
Patch Set: Just rebased on mkwst's changes Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_store_default.cc
diff --git a/components/password_manager/core/browser/password_store_default.cc b/components/password_manager/core/browser/password_store_default.cc
index ea493e321b3f399a4dbebdd695a2fdf472e59d8c..605f9b2be75a0a39730365aa6ea63e5d977a86d8 100644
--- a/components/password_manager/core/browser/password_store_default.cc
+++ b/components/password_manager/core/browser/password_store_default.cc
@@ -122,24 +122,21 @@ void PasswordStoreDefault::GetLoginsImpl(
}
void PasswordStoreDefault::GetAutofillableLoginsImpl(
- GetLoginsRequest* request) {
- // TODO(vabr) -- request should have a ScopedVector<autofill::PasswordForm>
- // instead of using |logins| here.
+ scoped_ptr<GetLoginsRequest> request) {
DCHECK(request->result()->empty());
ScopedVector<autofill::PasswordForm> logins;
FillAutofillableLogins(&logins);
vasilii 2015/02/09 10:08:35 Why not FillAutofillableLogins(request->result());
vabr (Chromium) 2015/02/09 11:36:06 Done.
logins.swap(*request->result());
- ForwardLoginsResult(request);
+ ForwardLoginsResult(request.Pass());
}
-void PasswordStoreDefault::GetBlacklistLoginsImpl(GetLoginsRequest* request) {
- // TODO(vabr) -- request should have a ScopedVector<autofill::PasswordForm>
- // instead of using |logins| here.
+void PasswordStoreDefault::GetBlacklistLoginsImpl(
+ scoped_ptr<GetLoginsRequest> request) {
DCHECK(request->result()->empty());
ScopedVector<autofill::PasswordForm> logins;
FillBlacklistLogins(&logins);
logins.swap(*request->result());
- ForwardLoginsResult(request);
+ ForwardLoginsResult(request.Pass());
}
bool PasswordStoreDefault::FillAutofillableLogins(

Powered by Google App Engine
This is Rietveld 408576698