GetLoginsRequest: Use ScopedVector to express ownership of forms

components/password_manager/core/browser/password_store_default.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/password_manager/core/browser/password_store_default.h"
 
 #include <set>
 
 #include "base/logging.h"
 #include "base/prefs/pref_service.h"
@@ skipping 104 matching lines @@
     const autofill::PasswordForm& form,
     AuthorizationPromptPolicy prompt_policy,
     const ConsumerCallbackRunner& callback_runner) {
   ScopedVector<autofill::PasswordForm> matched_forms;
   if (login_db_)
     login_db_->GetLogins(form, &matched_forms);
   callback_runner.Run(matched_forms.Pass());
 }
 
 void PasswordStoreDefault::GetAutofillableLoginsImpl(
-    GetLoginsRequest* request) {
-  // TODO(vabr) -- request should have a ScopedVector<autofill::PasswordForm>
-  // instead of using |logins| here.
+    scoped_ptr<GetLoginsRequest> request) {
   DCHECK(request->result()->empty());
   ScopedVector<autofill::PasswordForm> logins;
   FillAutofillableLogins(&logins);

[vasilii, 2015/02/09 10:08:35]

Why not FillAutofillableLogins(request->result()); here and below?

[vabr (Chromium), 2015/02/09 11:36:06]

Done.

   logins.swap(*request->result());
-  ForwardLoginsResult(request);
+  ForwardLoginsResult(request.Pass());
 }
 
-void PasswordStoreDefault::GetBlacklistLoginsImpl(GetLoginsRequest* request) {
-  // TODO(vabr) -- request should have a ScopedVector<autofill::PasswordForm>
-  // instead of using |logins| here.
+void PasswordStoreDefault::GetBlacklistLoginsImpl(
+    scoped_ptr<GetLoginsRequest> request) {
   DCHECK(request->result()->empty());
   ScopedVector<autofill::PasswordForm> logins;
   FillBlacklistLogins(&logins);
   logins.swap(*request->result());
-  ForwardLoginsResult(request);
+  ForwardLoginsResult(request.Pass());
 }
 
 bool PasswordStoreDefault::FillAutofillableLogins(
     ScopedVector<autofill::PasswordForm>* forms) {
   DCHECK(GetBackgroundTaskRunner()->BelongsToCurrentThread());
   return login_db_ && login_db_->GetAutofillableLogins(forms);
 }
 
 bool PasswordStoreDefault::FillBlacklistLogins(
     ScopedVector<autofill::PasswordForm>* forms) {
   DCHECK(GetBackgroundTaskRunner()->BelongsToCurrentThread());
   return login_db_ && login_db_->GetBlacklistLogins(forms);
 }
 
 }  // namespace password_manager