Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Unified Diff: components/password_manager/core/browser/test_password_store.h

Issue 866983003: GetLoginsRequest: Use ScopedVector to express ownership of forms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@324291_scopedvector
Patch Set: Fix Mac unittest Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/test_password_store.h
diff --git a/components/password_manager/core/browser/test_password_store.h b/components/password_manager/core/browser/test_password_store.h
index dd549aa8dc4ee92fd18009d150e59ce735f4ed02..5490eb00b1ce353d1d18b118479281c391ef85db 100644
--- a/components/password_manager/core/browser/test_password_store.h
+++ b/components/password_manager/core/browser/test_password_store.h
@@ -50,8 +50,7 @@ class TestPasswordStore : public PasswordStore {
void GetLoginsImpl(const autofill::PasswordForm& form,
PasswordStore::AuthorizationPromptPolicy prompt_policy,
const ConsumerCallbackRunner& runner) override;
- void GetAutofillableLoginsImpl(
- PasswordStore::GetLoginsRequest* request) override;
+ void GetAutofillableLoginsImpl(scoped_ptr<GetLoginsRequest> request) override;
// Unused portions of PasswordStore interface
void ReportMetricsImpl(const std::string& sync_username,
@@ -62,8 +61,7 @@ class TestPasswordStore : public PasswordStore {
PasswordStoreChangeList RemoveLoginsSyncedBetweenImpl(
base::Time delete_begin,
base::Time delete_end) override;
- void GetBlacklistLoginsImpl(
- PasswordStore::GetLoginsRequest* request) override {}
+ void GetBlacklistLoginsImpl(scoped_ptr<GetLoginsRequest> request) override {}
vasilii 2015/02/05 19:23:27 If we follow the guide line then the method isn't
vabr (Chromium) 2015/02/06 14:16:05 Agreed. Also done for ReportMetricsImpl for consis
bool FillAutofillableLogins(
ScopedVector<autofill::PasswordForm>* forms) override;
bool FillBlacklistLogins(

Powered by Google App Engine
This is Rietveld 408576698