GetLoginsRequest: Use ScopedVector to express ownership of forms

components/password_manager/core/browser/test_password_store.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_TEST_PASSWORD_STORE_H_
 #define COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_TEST_PASSWORD_STORE_H_
 
 #include <map>
 #include <string>
 #include <vector>
@@ skipping 32 matching lines @@
   // PasswordStore interface
   PasswordStoreChangeList AddLoginImpl(
       const autofill::PasswordForm& form) override;
   PasswordStoreChangeList UpdateLoginImpl(
       const autofill::PasswordForm& form) override;
   PasswordStoreChangeList RemoveLoginImpl(
       const autofill::PasswordForm& form) override;
   void GetLoginsImpl(const autofill::PasswordForm& form,
                      PasswordStore::AuthorizationPromptPolicy prompt_policy,
                      const ConsumerCallbackRunner& runner) override;
-  void GetAutofillableLoginsImpl(
-      PasswordStore::GetLoginsRequest* request) override;
+  void GetAutofillableLoginsImpl(scoped_ptr<GetLoginsRequest> request) override;
 
   // Unused portions of PasswordStore interface
   void ReportMetricsImpl(const std::string& sync_username,
                          bool custom_passphrase_sync_enabled) override {}
   PasswordStoreChangeList RemoveLoginsCreatedBetweenImpl(
       base::Time begin,
       base::Time end) override;
   PasswordStoreChangeList RemoveLoginsSyncedBetweenImpl(
       base::Time delete_begin,
       base::Time delete_end) override;
-  void GetBlacklistLoginsImpl(
-      PasswordStore::GetLoginsRequest* request) override {}
+  void GetBlacklistLoginsImpl(scoped_ptr<GetLoginsRequest> request) override {}

[vasilii, 2015/02/05 19:23:27]

If we follow the guide line then the method isn't so simple because it destroys
|request|. Regardless, I'd prefer to see both of them together in .cc.

[vabr (Chromium), 2015/02/06 14:16:05]

Agreed. Also done for ReportMetricsImpl for consistency.

Done.

   bool FillAutofillableLogins(
       ScopedVector<autofill::PasswordForm>* forms) override;
   bool FillBlacklistLogins(
       ScopedVector<autofill::PasswordForm>* forms) override;
 
  private:
   PasswordMap stored_passwords_;
 
   DISALLOW_COPY_AND_ASSIGN(TestPasswordStore);
 };
 
 }  // namespace password_manager
 
 #endif  // COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_TEST_PASSWORD_STORE_H_