GetLoginsRequest: Use ScopedVector to express ownership of forms

components/password_manager/core/browser/password_form_manager.h

Index: components/password_manager/core/browser/password_form_manager.h
diff --git a/components/password_manager/core/browser/password_form_manager.h b/components/password_manager/core/browser/password_form_manager.h
index efda7d3cf91490ceb1242a884e301d2c7b13310e..a804f8bdc16dc2cd3d8740893d79e00bb948e30c 100644
--- a/components/password_manager/core/browser/password_form_manager.h
+++ b/components/password_manager/core/browser/password_form_manager.h
@@ -10,6 +10,7 @@
 
 #include "build/build_config.h"
 
+#include "base/memory/scoped_vector.h"
 #include "base/memory/weak_ptr.h"
 #include "base/stl_util.h"
 #include "components/autofill/core/browser/field_types.h"
@@ -122,8 +123,7 @@ class PasswordFormManager : public PasswordStoreConsumer {
   // delayed until the data arrives.
   void ProcessFrame(const base::WeakPtr<PasswordManagerDriver>& driver);
 
-  void OnGetPasswordStoreResults(
-      const std::vector<autofill::PasswordForm*>& results) override;
+  void OnGetPasswordStoreResults() override;
 
   // A user opted to 'never remember' passwords for this form.
   // Blacklist it so that from now on when it is seen we ignore it.
@@ -225,7 +225,7 @@ class PasswordFormManager : public PasswordStoreConsumer {
 
   // Determines if we need to autofill given the results of the query.
   // Takes ownership of the elements in |result|.
-  void OnRequestDone(const std::vector<autofill::PasswordForm*>& result);
+  void OnRequestDone(ScopedVector<autofill::PasswordForm> result);
 
   // Helper for OnGetPasswordStoreResults to determine whether or not
   // the given result form is worth scoring.
@@ -285,6 +285,7 @@ class PasswordFormManager : public PasswordStoreConsumer {
   // Set of PasswordForms from the DB that best match the form
   // being managed by this. Use a map instead of vector, because we most
   // frequently require lookups by username value in IsNewLogin.
+  // TODO(vabr): Consider using ScopedPtrHashMap instead of the deleter below.
   autofill::PasswordFormMap best_matches_;
 
   // Cleans up when best_matches_ goes out of scope.