components/password_manager/core/browser/password_form_data.h - Issue 866983003: GetLoginsRequest: Use ScopedVector to express ownership of forms

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_form_data.h

Issue 866983003: GetLoginsRequest: Use ScopedVector to express ownership of forms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@324291_scopedvector

Patch Set: Rebased Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/password_manager/password_store_x_unittest.cc ('K') | « components/password_manager/core/browser/mock_password_store.h ('k') | components/password_manager/core/browser/password_form_manager.h » ('j') | components/password_manager/core/browser/password_form_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_form_data.h

diff --git a/components/password_manager/core/browser/password_form_data.h b/components/password_manager/core/browser/password_form_data.h

index b91a763f9a24897ba33fe958d42484fe6c04082c..333986596623423394212b69ac513236d65a268e 100644

--- a/components/password_manager/core/browser/password_form_data.h

+++ b/components/password_manager/core/browser/password_form_data.h

@@ -45,12 +45,6 @@ bool ContainsSamePasswordFormsPtr(

bool ContainsSamePasswordForms(std::vector<autofill::PasswordForm>& first,

std::vector<autofill::PasswordForm>& second);

-// This gmock matcher is used to check that the |arg| contains exactly the same

-// PasswordForms as |forms|, regardless of order.

-MATCHER_P(ContainsAllPasswordForms, forms, "") {

- return ContainsSamePasswordFormsPtr(forms, arg);

} // namespace password_manager

#endif // COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_FORM_DATA_H_