Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(952)

Issue 8669008: DestroyStreamTextureChromium should not disallow rendering (Closed)

Created:
9 years, 1 month ago by Min Qin
Modified:
7 years, 7 months ago
Reviewers:
greggman, no sievers
CC:
chromium-reviews, apatrick_chromium
Visibility:
Public.

Description

DestroyStreamTextureChromium should not disallow rendering This function just destroy the surfaceTexture. Disallow rendering should happen when we delete the gl texture. BUG= TEST=

Patch Set 1 #

Total comments: 1

Patch Set 2 : fixing the DCHECK instead #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M gpu/command_buffer/service/texture_manager.cc View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Min Qin
This fixes a DCHECK error in SetTarget in texture_manager.cc.
9 years, 1 month ago (2011-11-23 01:25:43 UTC) #1
greggman
http://codereview.chromium.org/8669008/diff/1/gpu/command_buffer/service/gles2_cmd_decoder.cc File gpu/command_buffer/service/gles2_cmd_decoder.cc (left): http://codereview.chromium.org/8669008/diff/1/gpu/command_buffer/service/gles2_cmd_decoder.cc#oldcode7480 gpu/command_buffer/service/gles2_cmd_decoder.cc:7480: texture_manager()->SetInfoTarget(feature_info_, info, 0); Something needs to happen here. The ...
9 years ago (2011-11-29 21:39:43 UTC) #2
Min Qin
On Tue, Nov 29, 2011 at 1:39 PM, <gman@chromium.org> wrote: > > http://codereview.chromium.**org/8669008/diff/1/gpu/** > command_buffer/service/gles2_**cmd_decoder.cc<http://codereview.chromium.org/8669008/diff/1/gpu/command_buffer/service/gles2_cmd_decoder.cc> ...
9 years ago (2011-11-29 22:09:09 UTC) #3
Min Qin
9 years ago (2011-11-29 22:44:35 UTC) #4
Added back the setTargetInfo call and fixed the DCHECK in setTarget.

Powered by Google App Engine
This is Rietveld 408576698