DestroyStreamTextureChromium should not disallow rendering

gpu/command_buffer/service/gles2_cmd_decoder.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/gles2_cmd_decoder.h"
 
 #include <stdio.h>
 
 #include <algorithm>
 #include <list>
@@ skipping 7459 matching lines @@
     const gles2::DestroyStreamTextureCHROMIUM& c) {
   GLuint client_id = c.texture;
   TextureManager::TextureInfo* info =
       texture_manager()->GetTextureInfo(client_id);
   if (info && info->IsStreamTexture()) {
     if (!stream_texture_manager_)
       return error::kInvalidArguments;
 
     stream_texture_manager_->DestroyStreamTexture(info->service_id());
     info->SetStreamTexture(false);
-    texture_manager()->SetInfoTarget(feature_info_, info, 0);

[greggman, 2011/11/29 21:39:43]

Something needs to happen here. The texture is going from a stream texture to a
non-stream texture.

Setting it back to 0 means if you bind it again it will become renderable. Maybe
you want to set it to TEXTURE_2D instead of 0? That seems iffy.

Although, there is a DCHECK in TextureInfo::SetTarget to ensure this gets set
only once. You probably need to change that check so that it's okay to set IF it
used to be a GL_TEXTURE_EXTERNAL_OES

   } else {
     SetGLError(GL_INVALID_VALUE,
                "glDestroyStreamTextureCHROMIUM: bad texture id.");
   }
 
   return error::kNoError;
 }
 
 // Include the auto-generated part of this file. We split this because it means
 // we can easily edit the non-auto generated parts right here in this file
 // instead of having to edit some template or the code generator.
 #include "gpu/command_buffer/service/gles2_cmd_decoder_autogen.h"
 
 }  // namespace gles2
 }  // namespace gpu