Contribution of PowerPC port (continuation of 422063005) - AIX Common1

src/d8.cc

Index: src/d8.cc
diff --git a/src/d8.cc b/src/d8.cc
index 7157cb81acf85171b94e331ad02e8404323dd0c5..6b4d86f162a9f82e3114a26b18b8dc737bd4ad54 100644
--- a/src/d8.cc
+++ b/src/d8.cc
@@ -62,6 +62,10 @@
 #define DCHECK(condition) assert(condition)
 #endif
 
+#if V8_OS_AIX
+#define malloc __linux_malloc

[Sven Panne, 2015/01/27 11:47:06]

Why do we need this? A comment would be nice.

[michael_dawson, 2015/01/29 00:08:29]

This is the comment I'll add explaining:
// On AIX if you call malloc with a size of 0 malloc fails.  On linux it
// allocates a minimum amount.  This seems to be used for things like
// finding out where the heap is located.  Using __linux_malloc makes
// the behaviour when running on AIX compatible with what is seen on linux

[Sven Panne, 2015/01/29 09:54:33]

Hmmm, if I see this correctly, malloc(0) only happens via the
MockArrayBufferAllocator. I would prefer to leave out this #ifdef and change
MockArrayBufferAllocator to allocate a single byte instead. This should
hopefully work, if not, we learn something. :-)

As a side note, this would probably be more correct, anyway: POSIX explicitly
states that malloc(0) has implementation-defined behavior (either returning NULL
or a unique pointer).

[michael_dawson, 2015/01/29 18:21:58]

Will do

+#endif
+
 namespace v8 {