Contribution of PowerPC port (continuation of 422063005) - AIX Common1

src/d8.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 
 // Defined when linking against shared lib on Windows.
 #if defined(USING_V8_SHARED) && !defined(V8_SHARED)
 #define V8_SHARED
 #endif
 
@@ skipping 44 matching lines @@
 #include <windows.h>  // NOLINT
 #if defined(_MSC_VER)
 #include <crtdbg.h>  // NOLINT
 #endif               // defined(_MSC_VER)
 #endif               // !defined(_WIN32) && !defined(_WIN64)
 
 #ifndef DCHECK
 #define DCHECK(condition) assert(condition)
 #endif
 
+#if V8_OS_AIX
+#define malloc __linux_malloc

[Sven Panne, 2015/01/27 11:47:06]

Why do we need this? A comment would be nice.

[michael_dawson, 2015/01/29 00:08:29]

This is the comment I'll add explaining:
// On AIX if you call malloc with a size of 0 malloc fails.  On linux it
// allocates a minimum amount.  This seems to be used for things like
// finding out where the heap is located.  Using __linux_malloc makes
// the behaviour when running on AIX compatible with what is seen on linux

[Sven Panne, 2015/01/29 09:54:33]

Hmmm, if I see this correctly, malloc(0) only happens via the
MockArrayBufferAllocator. I would prefer to leave out this #ifdef and change
MockArrayBufferAllocator to allocate a single byte instead. This should
hopefully work, if not, we learn something. :-)

As a side note, this would probably be more correct, anyway: POSIX explicitly
states that malloc(0) has implementation-defined behavior (either returning NULL
or a unique pointer).

[michael_dawson, 2015/01/29 18:21:58]

Will do

+#endif
+
 namespace v8 {
 
 
 static Handle<Value> Throw(Isolate* isolate, const char* message) {
   return isolate->ThrowException(String::NewFromUtf8(isolate, message));
 }
 
 
 
 class PerIsolateData {
@@ skipping 1675 matching lines @@
 }
 
 }  // namespace v8
 
 
 #ifndef GOOGLE3
 int main(int argc, char* argv[]) {
   return v8::Shell::Main(argc, argv);
 }
 #endif