Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 866753002: Fix the 'for' attribute check in presubmit. (Closed)

Created:
5 years, 11 months ago by pneubeck (no reviews)
Modified:
5 years, 11 months ago
Reviewers:
Dan Beam, Evan Stade
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the 'for' attribute check in presubmit. BUG=451029 Committed: https://crrev.com/a36f90407f3ba76481afdbd091f674ef2aba0c9f Cr-Commit-Position: refs/heads/master@{#313014}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added a test for the presubmit check. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -2 lines) Patch
M chrome/browser/test_presubmit.py View 1 2 chunks +43 lines, -1 line 0 comments Download
M chrome/browser/web_dev_style/html_checker.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
pneubeck (no reviews)
Dan, ptal Evan: FYI
5 years, 11 months ago (2015-01-22 15:02:26 UTC) #2
Dan Beam
https://codereview.chromium.org/866753002/diff/1/chrome/browser/web_dev_style/html_checker.py File chrome/browser/web_dev_style/html_checker.py (right): https://codereview.chromium.org/866753002/diff/1/chrome/browser/web_dev_style/html_checker.py#newcode20 chrome/browser/web_dev_style/html_checker.py:20: r"(?:^|\s)(for=)", can you please add a test for this ...
5 years, 11 months ago (2015-01-22 16:39:17 UTC) #3
Evan Stade
lgtm, thanks
5 years, 11 months ago (2015-01-22 17:00:24 UTC) #4
pneubeck (no reviews)
ptal
5 years, 11 months ago (2015-01-23 12:21:15 UTC) #5
Dan Beam
lgtm++
5 years, 11 months ago (2015-01-23 19:04:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/866753002/20001
5 years, 11 months ago (2015-01-24 09:34:21 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-24 09:37:39 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-24 09:38:40 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a36f90407f3ba76481afdbd091f674ef2aba0c9f
Cr-Commit-Position: refs/heads/master@{#313014}

Powered by Google App Engine
This is Rietveld 408576698