Fix the 'for' attribute check in presubmit.

chrome/browser/test_presubmit.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Unit tests for Web Development Style Guide checker."""
 
 import os
 import re
 import sys
 import unittest
 
 test_dir = os.path.dirname(os.path.abspath(__file__))
 sys.path.extend([
     os.path.normpath(os.path.join(test_dir, '..', '..', 'tools')),
     os.path.join(test_dir),
 ])
 
 import find_depot_tools # pylint: disable=W0611
 from testing_support.super_mox import SuperMoxTestBase
-from web_dev_style import resource_checker, css_checker, js_checker # pylint: disable=F0401
+from web_dev_style import css_checker, html_checker, js_checker, \
+     resource_checker  # pylint: disable=F0401
 
 
 def GetHighlight(line, error):
   """Returns the substring of |line| that is highlighted in |error|."""
   error_lines = error.split('\n')
   highlight = error_lines[error_lines.index(line) + 1]
   return ''.join(ch1 for (ch1, ch2) in zip(line, highlight) if ch2 == '^')
 
 
+class HtmlStyleTest(SuperMoxTestBase):
+  def setUp(self):
+    SuperMoxTestBase.setUp(self)
+
+    input_api = self.mox.CreateMockAnything()
+    input_api.re = re
+    output_api = self.mox.CreateMockAnything()
+    self.checker = html_checker.HtmlChecker(input_api, output_api)
+
+  def ShouldFailLabelCheck(self, line):
+    """Checks that the label checker flags |line| as a style error."""
+    error = self.checker.LabelCheck(1, line)
+    self.assertNotEqual('', error, 'Should be flagged as style error: ' + line)
+    highlight = GetHighlight(line, error).strip()
+    self.assertEqual('for=', highlight)
+
+  def ShouldPassLabelCheck(self, line):
+    """Checks that the label checker doesn't flag |line| as a style error."""
+    error = self.checker.LabelCheck(1, line)
+    self.assertEqual('', error, 'Should not be flagged as style error: ' + line)
+
+  def testForAttributeFails(self):
+    lines = [
+      " for=\"abc\"",
+      "for=    ",
+      " \tfor=    ",
+      "   for="
+    ]
+    for line in lines:
+      self.ShouldFailLabelCheck(line)
+
+  def testOtherAttributesPass(self):
+    lines = [
+      " my-for=\"abc\" ",
+      " myfor=\"abc\" ",
+      " <for",
+    ]
+    for line in lines:
+      self.ShouldPassLabelCheck(line)
+
+
 class ResourceStyleGuideTest(SuperMoxTestBase):
   def setUp(self):
     SuperMoxTestBase.setUp(self)
 
     input_api = self.mox.CreateMockAnything()
     input_api.re = re
     output_api = self.mox.CreateMockAnything()
     self.checker = resource_checker.ResourceChecker(input_api, output_api)
 
   def ShouldFailIncludeCheck(self, line):
@@ skipping 786 matching lines @@
     opacity: .0;
     opacity: 0.0;
     opacity: 0.;
     border-width: 0mm;
     height: 0cm;
     width: 0in;
 """)
 
 if __name__ == '__main__':
   unittest.main()