partial PageClickTracker migration to RenderFrameObserver

partial PageClickTracker migration to RenderFrameObserver

BUG=433486
Committed: https://crrev.com/78d655f812267ed45a3e90faecbd000fe9bd359a
Cr-Commit-Position: refs/heads/master@{#313856}

[Evan Stade, 2015-01-22 00:54:07]

estade@chromium.org changed reviewers:
+ nasko@chromium.org

[Evan Stade, 2015-01-22 00:55:38]

Do you know if there's a bug to track progress on updating the input
handling/forwarding in RenderWidget::OnHandleInputEvent to be frame-based
instead of webview-based?

[nasko, 2015-01-22 20:58:59]

content/ LGTM

I don't know if we have a bug that tracks input migration. I couldn't find one.

https://codereview.chromium.org/866633002/diff/40001/content/renderer/render_...
File content/renderer/render_view_impl.cc (right):

https://codereview.chromium.org/866633002/diff/40001/content/renderer/render_...
content/renderer/render_view_impl.cc:1941: // TODO(dmazzoni): remove once
there's a separate a11y tree per frame.
nit: no space in "separate a11y"

[Evan Stade, 2015-01-22 21:02:38]

https://codereview.chromium.org/866633002/diff/40001/content/renderer/render_...
File content/renderer/render_view_impl.cc (right):

https://codereview.chromium.org/866633002/diff/40001/content/renderer/render_...
content/renderer/render_view_impl.cc:1941: // TODO(dmazzoni): remove once
there's a separate a11y tree per frame.
On 2015/01/22 20:58:58, nasko wrote:
> nit: no space in "separate a11y"

oops, this is a change from https://codereview.chromium.org/812033016/ (which
this patch depends on)

I'm not sure what you mean by no space though?

[nasko, 2015-01-22 21:22:25]

On 2015/01/22 21:02:38, Evan Stade wrote:
>
https://codereview.chromium.org/866633002/diff/40001/content/renderer/render_...
> File content/renderer/render_view_impl.cc (right):
> 
>
https://codereview.chromium.org/866633002/diff/40001/content/renderer/render_...
> content/renderer/render_view_impl.cc:1941: // TODO(dmazzoni): remove once
> there's a separate a11y tree per frame.
> On 2015/01/22 20:58:58, nasko wrote:
> > nit: no space in "separate a11y"
> 
> oops, this is a change from https://codereview.chromium.org/812033016/ (which
> this patch depends on)
> 
> I'm not sure what you mean by no space though?

Oh, my brain read it as "separately", I realize my mistake now.
Thanks.

[Evan Stade, 2015-01-23 16:07:55]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2015-01-23 16:08:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/866633002/60001

[commit-bot: I haz the power, 2015-01-23 16:18:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-23 16:18:48]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Evan Stade, 2015-01-23 22:38:24]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2015-01-23 22:39:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/866633002/80001

[commit-bot: I haz the power, 2015-01-23 22:55:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-23 22:55:51]

Try jobs failed on following builders:
  linux_chromium_gn_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Evan Stade, 2015-01-26 20:05:46]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2015-01-26 20:07:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/866633002/100001

[commit-bot: I haz the power, 2015-01-26 20:42:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-26 20:42:02]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Evan Stade, 2015-01-27 02:12:57]

estade@chromium.org changed reviewers:
+ groby@chromium.org

[Evan Stade, 2015-01-27 02:12:58]

+groby for spellchecker change

[groby-ooo-7-16, 2015-01-27 02:31:21]

spellcheck LGTM

https://codereview.chromium.org/866633002/diff/120001/chrome/renderer/spellch...
File chrome/renderer/spellchecker/spellcheck_provider.cc (right):

https://codereview.chromium.org/866633002/diff/120001/chrome/renderer/spellch...
chrome/renderer/spellchecker/spellcheck_provider.cc:114: WebFrame* frame =
render_view()->GetWebView()->focusedFrame();
RenderViewImpl::GetFocusedElement() already does all the frame stuff - I assume
this is lifted out because we need to use |frame| for |checked| anyways?

[Evan Stade, 2015-01-27 02:36:56]

https://codereview.chromium.org/866633002/diff/120001/chrome/renderer/spellch...
File chrome/renderer/spellchecker/spellcheck_provider.cc (right):

https://codereview.chromium.org/866633002/diff/120001/chrome/renderer/spellch...
chrome/renderer/spellchecker/spellcheck_provider.cc:114: WebFrame* frame =
render_view()->GetWebView()->focusedFrame();
On 2015/01/27 02:31:21, groby wrote:
> RenderViewImpl::GetFocusedElement() already does all the frame stuff - I
assume
> this is lifted out because we need to use |frame| for |checked| anyways?

RenderView::GetFocusedElement() is going away (and more generally, RenderView is
going away)

[Evan Stade, 2015-01-27 02:37:00]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2015-01-27 02:38:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/866633002/120001

[commit-bot: I haz the power, 2015-01-27 03:55:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-27 03:55:42]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Evan Stade, 2015-01-27 18:49:34]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2015-01-27 18:50:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/866633002/120001

[commit-bot: I haz the power, 2015-01-27 18:51:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-27 18:51:05]

Try jobs failed on following builders:
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/11...)
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_rel_ng on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Evan Stade, 2015-01-28 02:08:50]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2015-01-28 02:09:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/866633002/120001

[commit-bot: I haz the power, 2015-01-28 03:22:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-28 03:22:48]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Evan Stade, 2015-01-28 22:53:42]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2015-01-28 22:55:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/866633002/120001

[commit-bot: I haz the power, 2015-01-29 00:13:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-29 00:13:24]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Evan Stade, 2015-01-29 03:12:52]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2015-01-29 03:13:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/866633002/140001

[commit-bot: I haz the power, 2015-01-29 03:29:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-29 03:29:33]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Evan Stade, 2015-01-29 03:53:43]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2015-01-29 03:54:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/866633002/180001

[commit-bot: I haz the power, 2015-01-29 04:59:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-29 04:59:49]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Evan Stade, 2015-01-30 00:47:25]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2015-01-30 00:48:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/866633002/200001

[commit-bot: I haz the power, 2015-01-30 01:55:40]

Committed patchset #11 (id:200001)

[commit-bot: I haz the power, 2015-01-30 01:56:33]

Patchset 11 (id:??) landed as
https://crrev.com/78d655f812267ed45a3e90faecbd000fe9bd359a
Cr-Commit-Position: refs/heads/master@{#313856}