Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Side by Side Diff: chrome/renderer/autofill/page_click_tracker_browsertest.cc

Issue 866633002: partial PageClickTracker migration to RenderFrameObserver (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: make test happy Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/renderer/spellchecker/spellcheck_provider.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/basictypes.h" 5 #include "base/basictypes.h"
6 #include "chrome/test/base/chrome_render_view_test.h" 6 #include "chrome/test/base/chrome_render_view_test.h"
7 #include "components/autofill/content/renderer/page_click_listener.h" 7 #include "components/autofill/content/renderer/page_click_listener.h"
8 #include "components/autofill/content/renderer/page_click_tracker.h" 8 #include "components/autofill/content/renderer/page_click_tracker.h"
9 #include "content/public/renderer/render_view.h" 9 #include "content/public/renderer/render_view.h"
10 #include "testing/gtest/include/gtest/gtest.h" 10 #include "testing/gtest/include/gtest/gtest.h"
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 bool was_focused_; 43 bool was_focused_;
44 }; 44 };
45 45
46 class PageClickTrackerTest : public ChromeRenderViewTest { 46 class PageClickTrackerTest : public ChromeRenderViewTest {
47 protected: 47 protected:
48 void SetUp() override { 48 void SetUp() override {
49 ChromeRenderViewTest::SetUp(); 49 ChromeRenderViewTest::SetUp();
50 50
51 // RenderView creates PageClickTracker but it doesn't keep it around. 51 // RenderView creates PageClickTracker but it doesn't keep it around.
52 // Rather than make it do so for the test, we create a new object. 52 // Rather than make it do so for the test, we create a new object.
53 page_click_tracker_.reset(new PageClickTracker(view_, &test_listener_)); 53 page_click_tracker_.reset(new PageClickTracker(view_->GetMainRenderFrame(),
54 &test_listener_));
54 55
55 // Must be set before loading HTML. 56 // Must be set before loading HTML.
56 view_->GetWebView()->setDefaultPageScaleLimits(1, 4); 57 view_->GetWebView()->setDefaultPageScaleLimits(1, 4);
57 view_->GetWebView()->settings()->setPinchVirtualViewportEnabled(true); 58 view_->GetWebView()->settings()->setPinchVirtualViewportEnabled(true);
58 59
59 LoadHTML("<form>" 60 LoadHTML("<form>"
60 " <input type='text' id='text_1'></input><br>" 61 " <input type='text' id='text_1'></input><br>"
61 " <input type='text' id='text_2'></input><br>" 62 " <input type='text' id='text_2'></input><br>"
62 " <textarea id='textarea_1'></textarea><br>" 63 " <textarea id='textarea_1'></textarea><br>"
63 " <textarea id='textarea_2'></textarea><br>" 64 " <textarea id='textarea_2'></textarea><br>"
(...skipping 119 matching lines...) Expand 10 before | Expand all | Expand 10 after
183 EXPECT_FALSE(test_listener_.was_focused_); 184 EXPECT_FALSE(test_listener_.was_focused_);
184 EXPECT_TRUE(text_ == test_listener_.form_control_element_clicked_); 185 EXPECT_TRUE(text_ == test_listener_.form_control_element_clicked_);
185 test_listener_.ClearResults(); 186 test_listener_.ClearResults();
186 187
187 // Click the disabled element. 188 // Click the disabled element.
188 EXPECT_TRUE(SimulateElementClick("button_2")); 189 EXPECT_TRUE(SimulateElementClick("button_2"));
189 EXPECT_FALSE(test_listener_.form_control_element_clicked_called_); 190 EXPECT_FALSE(test_listener_.form_control_element_clicked_called_);
190 } 191 }
191 192
192 } // namespace autofill 193 } // namespace autofill
OLDNEW
« no previous file with comments | « no previous file | chrome/renderer/spellchecker/spellcheck_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698