Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 866213004: Switch Sky to pointer events (Closed)

Created:
5 years, 11 months ago by abarth-chromium
Modified:
5 years, 11 months ago
Reviewers:
ojan
CC:
eseidel, esprehn, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Switch Sky to pointer events This CL switches Sky to a pointer events model that unifies mouse and touch with a common event model. This implementation is just enough to make the example widgets work. The rest of the design is in the specs, which we hope to converge with over time. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/0f185a7b8d22b52b921fd4c399256a83d5639981

Patch Set 1 #

Patch Set 2 : nits #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -129 lines) Patch
M sky/engine/core/frame/LocalFrame.h View 4 chunks +9 lines, -0 lines 0 comments Download
M sky/engine/core/frame/LocalFrame.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M sky/engine/core/frame/NewEventHandler.h View 2 chunks +2 lines, -1 line 2 comments Download
M sky/engine/core/frame/NewEventHandler.cpp View 3 chunks +6 lines, -5 lines 0 comments Download
M sky/engine/public/platform/WebInputEvent.h View 1 chunk +8 lines, -0 lines 2 comments Download
M sky/engine/web/WebViewImpl.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
M sky/framework/sky-button/sky-button.sky View 2 chunks +6 lines, -6 lines 0 comments Download
M sky/framework/sky-checkbox/sky-checkbox.sky View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/framework/sky-radio/sky-radio.sky View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/viewer/converters/input_event_types.cc View 1 4 chunks +40 lines, -113 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
abarth-chromium
5 years, 11 months ago (2015-01-23 07:49:41 UTC) #1
ojan
lgtm https://codereview.chromium.org/866213004/diff/20001/sky/engine/core/frame/NewEventHandler.h File sky/engine/core/frame/NewEventHandler.h (right): https://codereview.chromium.org/866213004/diff/20001/sky/engine/core/frame/NewEventHandler.h#newcode40 sky/engine/core/frame/NewEventHandler.h:40: typedef std::map<int, RefPtr<Node>> PointerTargetMap; Why didn't HashMap work? ...
5 years, 11 months ago (2015-01-23 10:23:55 UTC) #3
abarth-chromium
https://codereview.chromium.org/866213004/diff/20001/sky/engine/core/frame/NewEventHandler.h File sky/engine/core/frame/NewEventHandler.h (right): https://codereview.chromium.org/866213004/diff/20001/sky/engine/core/frame/NewEventHandler.h#newcode40 sky/engine/core/frame/NewEventHandler.h:40: typedef std::map<int, RefPtr<Node>> PointerTargetMap; On 2015/01/23 at 10:23:55, ojan ...
5 years, 11 months ago (2015-01-23 16:51:33 UTC) #4
abarth-chromium
5 years, 11 months ago (2015-01-23 17:38:50 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
0f185a7b8d22b52b921fd4c399256a83d5639981 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698