Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(822)

Unified Diff: sky/framework/sky-checkbox/sky-checkbox.sky

Issue 866213004: Switch Sky to pointer events (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: nits Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/framework/sky-checkbox/sky-checkbox.sky
diff --git a/sky/framework/sky-checkbox/sky-checkbox.sky b/sky/framework/sky-checkbox/sky-checkbox.sky
index 14db2c6f0a8e8d3be8f64a4439f2ab10c38f0eb9..766f2354f593d6fe330710e5cd616b4972d38814 100644
--- a/sky/framework/sky-checkbox/sky-checkbox.sky
+++ b/sky/framework/sky-checkbox/sky-checkbox.sky
@@ -8,7 +8,7 @@
<sky-element
name="sky-checkbox"
attributes="checked:boolean"
- on-mouseup="handleMouseUp">
+ on-click="handleClick">
<template>
<style>
:host {
@@ -65,7 +65,7 @@ module.exports = class extends SkyButton {
highlightChanged(oldValue, newValue) {
this.containerStyle = newValue ? 'highlight' : '';
}
- handleMouseUp() {
+ handleClick() {
this.checked = !this.checked;
}
}.register();

Powered by Google App Engine
This is Rietveld 408576698