Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 866143002: Upload some update_client test files (Closed)

Created:
5 years, 11 months ago by Sorin Jianu
Modified:
5 years, 11 months ago
Reviewers:
waffles, blundell
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

This is related to https://codereview.chromium.org/808773005/ The idea here is that for reasons not fully understood at the moment, the files in this CL failed the checkperms script, so 808773005 can't land. This CL attempt to land the offending files, with two goals in mind. First, unblock 80877300. Second, provide a clear repro for the chrome-infra team to look at, in case something fails. There is something going on uploading binary patches and permissions using git cl upload. BUG=450337 R=blundell@chromium.org, waffles@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/d2e1ece564dc9b309d8d97bd988e635b5cb41047

Patch Set 1 #

Patch Set 2 : rebase #

Messages

Total messages: 6 (1 generated)
waffles
lgtm, I hope the trybots pass.
5 years, 11 months ago (2015-01-22 21:14:57 UTC) #2
Sorin Jianu
Colin, can you please look at this CL. I hope the description is sufficient, please ...
5 years, 11 months ago (2015-01-22 21:27:46 UTC) #3
blundell
lgtm
5 years, 11 months ago (2015-01-23 08:51:52 UTC) #4
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/d2e1ece564dc9b309d8d97bd988e635b5cb41047 Cr-Commit-Position: refs/heads/master@{#312921}
5 years, 11 months ago (2015-01-23 20:54:20 UTC) #5
Sorin Jianu
5 years, 11 months ago (2015-01-23 20:54:29 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d2e1ece564dc9b309d8d97bd988e635b5cb41047 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698