Cleanup the android scripts.

Cleanup the android scripts.

Rename a few files to make their function clearer.
Update other files to remove dead code or improve function.

Committed: https://skia.googlesource.com/skia/+/6429fd1e41129fb960d1ff341a1befe8ac932600

[djsollen, 2015-02-03 16:01:42]

djsollen@google.com changed reviewers:
+ borenet@google.com, scroggo@google.com, tomhudson@chromium.org

[borenet, 2015-02-03 16:04:57]

https://codereview.chromium.org/865943007/diff/1/platform_tools/android/bin/a...
File platform_tools/android/bin/android_gdb_app (right):

https://codereview.chromium.org/865943007/diff/1/platform_tools/android/bin/a...
platform_tools/android/bin/android_gdb_app:34: #adb_pull_if_needed
/data/data/com.skia/lib/libskia_android.so $GDB_TMP_DIR
Intentional?

https://codereview.chromium.org/865943007/diff/1/platform_tools/android/bin/a...
platform_tools/android/bin/android_gdb_app:69: #rm -rf $GDB_TMP_DIR
Intentional?

[djsollen, 2015-02-03 16:07:15]

https://codereview.chromium.org/865943007/diff/1/platform_tools/android/bin/a...
File platform_tools/android/bin/android_gdb_app (right):

https://codereview.chromium.org/865943007/diff/1/platform_tools/android/bin/a...
platform_tools/android/bin/android_gdb_app:34: #adb_pull_if_needed
/data/data/com.skia/lib/libskia_android.so $GDB_TMP_DIR
On 2015/02/03 16:04:57, borenet wrote:
> Intentional?

yes, but after more diagnosis I can add this back.

https://codereview.chromium.org/865943007/diff/1/platform_tools/android/bin/a...
platform_tools/android/bin/android_gdb_app:69: #rm -rf $GDB_TMP_DIR
On 2015/02/03 16:04:57, borenet wrote:
> Intentional?

Yes, running back to back gdb sessions takes much too long as we have to repull
all the libraries.  I would rather we leave the directory for the user to
cleanup instead of causing a ~1 minute delay every time you try to attach a
debugger.

[borenet, 2015-02-03 16:19:04]

https://codereview.chromium.org/865943007/diff/1/platform_tools/android/bin/a...
File platform_tools/android/bin/android_gdb_app (right):

https://codereview.chromium.org/865943007/diff/1/platform_tools/android/bin/a...
platform_tools/android/bin/android_gdb_app:69: #rm -rf $GDB_TMP_DIR
On 2015/02/03 16:07:15, djsollen wrote:
> On 2015/02/03 16:04:57, borenet wrote:
> > Intentional?
> 
> Yes, running back to back gdb sessions takes much too long as we have to
repull
> all the libraries.  I would rather we leave the directory for the user to
> cleanup instead of causing a ~1 minute delay every time you try to attach a
> debugger.

Ok, can we either remove the line or add a comment explaining why it's commented
out and when we can uncomment?

[djsollen, 2015-02-03 16:24:09]

Done. I just forgot to hit save the first time

[borenet, 2015-02-03 16:34:54]

LGTM

[djsollen, 2015-02-03 19:36:45]

The CQ bit was checked by djsollen@google.com

[commit-bot: I haz the power, 2015-02-03 19:36:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/865943007/40001

[commit-bot: I haz the power, 2015-02-03 21:37:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-03 21:37:02]

Try jobs failed on following builders:
  Build-Mac10.8-Clang-x86_64-Release-Trybot on client.skia.compile (None)
  Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on client.skia.compile (None)
  Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot on client.skia.compile
(None)
  Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot on client.skia.compile (None)
  Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile (None)

[djsollen, 2015-02-03 22:20:31]

The CQ bit was checked by djsollen@google.com

[commit-bot: I haz the power, 2015-02-03 22:21:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/865943007/40001

[commit-bot: I haz the power, 2015-02-03 23:07:34]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/6429fd1e41129fb960d1ff341a1befe8ac932600

[scroggo, 2015-02-09 14:03:33]

LGTM

Thanks for the clearer names!

https://codereview.chromium.org/865943007/diff/40001/platform_tools/android/b...
File platform_tools/android/bin/android_gdb_native (right):

https://codereview.chromium.org/865943007/diff/40001/platform_tools/android/b...
platform_tools/android/bin/android_gdb_native:54: # to remove the directory when
they are done debugging.
Any way for the user to know this? If it ever matters, should we add a
convenient way to do this?

https://codereview.chromium.org/865943007/diff/40001/site/user/quick/android.md
File site/user/quick/android.md (left):

https://codereview.chromium.org/865943007/diff/40001/site/user/quick/android....
site/user/quick/android.md:153: Debugging on Android
Should this also mention android_gdb_app?

[djsollen, 2015-02-10 13:47:20]

https://codereview.chromium.org/865943007/diff/40001/platform_tools/android/b...
File platform_tools/android/bin/android_gdb_native (right):

https://codereview.chromium.org/865943007/diff/40001/platform_tools/android/b...
platform_tools/android/bin/android_gdb_native:54: # to remove the directory when
they are done debugging.
On 2015/02/09 14:03:32, scroggo wrote:
> Any way for the user to know this? If it ever matters, should we add a
> convenient way to do this?

I think it is more convenient to just rm -rf the directory than adding an option
to the debugging script to do it for them.

https://codereview.chromium.org/865943007/diff/40001/site/user/quick/android.md
File site/user/quick/android.md (left):

https://codereview.chromium.org/865943007/diff/40001/site/user/quick/android....
site/user/quick/android.md:153: Debugging on Android
On 2015/02/09 14:03:32, scroggo wrote:
> Should this also mention android_gdb_app?

CL is on the way.