Chromium Code Reviews| Index: platform_tools/android/bin/android_gdb_native |
| diff --git a/platform_tools/android/bin/android_gdb_exe b/platform_tools/android/bin/android_gdb_native |
| similarity index 75% |
| rename from platform_tools/android/bin/android_gdb_exe |
| rename to platform_tools/android/bin/android_gdb_native |
| index 42299949123abfbcd417147856bcba19c175a562..e7bd6367cbe7bc0648f36cfe5e624e97be1e0bba 100755 |
| --- a/platform_tools/android/bin/android_gdb_exe |
| +++ b/platform_tools/android/bin/android_gdb_native |
| @@ -1,6 +1,7 @@ |
| #!/bin/bash |
| # |
| -# android_gdb: Pushes gdbserver. Connects and enters debugging environment. |
| +# android_gdb_native: Pushes gdbserver, connects to specified Skia app, |
| +# and enters command line debugging environment. |
| SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )" |
| source $SCRIPT_DIR/android_setup.sh |
| @@ -47,5 +48,8 @@ echo "Entering gdb client shell" |
| GDB_COMMAND=$(command ls "$ANDROID_TOOLCHAIN"/*-gdb | head -n1) |
| "$GDB_COMMAND" -x $GDBSETUP |
| -# Clean up |
| -rm -rf $GDB_TMP_DIR |
| +# Clean up: |
| +# We could 'rm -rf $GDB_TMP_DIR', but doing so would cause subsequent debugging |
| +# sessions to take longer than necessary. The tradeoff is to now force the user |
| +# to remove the directory when they are done debugging. |
|
scroggo
2015/02/09 14:03:32
Any way for the user to know this? If it ever matt
djsollen
2015/02/10 13:47:20
I think it is more convenient to just rm -rf the d
|
| +rm $GDBSETUP |