Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 865673003: Revert "compositor: Fix texture flipping for SW mirroring with surfaceless" (Closed)

Created:
5 years, 10 months ago by oshima
Modified:
5 years, 10 months ago
CC:
chromium-reviews, sadrul, Ian Vollick, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, kalyank, cc-bugs_chromium.org, danakj+watch_chromium.org, Daniel Kurtz
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

This reverts two CLs "compositor: Fix texture flipping for SW mirroring with surfaceless" and "Exclude reflector_impl_unittest.cc from GN non-Aura, non-Mac builds." Reason for revert: The original patch breaks software mirroring mode on at least veyron_jerry, and quite possibly all non-freon systems. >Original issue's descriptions: > Exclude reflector_impl_unittest.cc from GN non-Aura, non-Mac builds. > This fixes the GN build on Android after https://codereview.chromium.org/846063002. > > (The GYP build didn't break because content/browser/compositor/ is completely excluded there; see https://code.google.com/p/chromium/codesearch#chromium/src/content/content_tests.gypi&sq=package:chromium&&type=cs&l=1099) > > TBR=bauerb@chromium.org > > Review URL: https://codereview.chromium.org/879543002 > > Cr-Commit-Position: refs/heads/master@{#313074} > compositor: Fix texture flipping for SW mirroring with surfaceless > > Ozone-surfaceless renders the scene flipped, so the texture contents are > inverted from what they should be. This fixes the mirroring logic to > un-flip the texture when needed, and also to send the right sub-buffer > update rect. > > BUG=434115 > > Committed: https://crrev.com/c6a481fe79e0c4851a576495105edf2600bfe5be > Cr-Commit-Position: refs/heads/master@{#312979} TBR=danakj@chromium.org,achaulk@chromium.org,bauerb@chromium.org BUG=434115, 451804 Committed: https://crrev.com/6302d690c0b3aa762b92300564d9313876c6a2bf Cr-Commit-Position: refs/heads/master@{#313610}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -223 lines) Patch
M cc/layers/texture_layer.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/compositor/browser_compositor_output_surface.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/compositor/browser_compositor_output_surface.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/compositor/reflector_impl.h View 5 chunks +4 lines, -10 lines 0 comments Download
M content/browser/compositor/reflector_impl.cc View 4 chunks +8 lines, -15 lines 0 comments Download
D content/browser/compositor/reflector_impl_unittest.cc View 1 chunk +0 lines, -155 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ui/compositor/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ui/compositor/compositor.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ui/compositor/layer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/compositor/layer.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M ui/compositor/reflector.h View 1 chunk +4 lines, -6 lines 0 comments Download
D ui/compositor/reflector.cc View 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
oshima
5 years, 10 months ago (2015-01-28 20:18:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/865673003/1
5 years, 10 months ago (2015-01-28 20:19:28 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/53996)
5 years, 10 months ago (2015-01-28 20:36:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/865673003/20001
5 years, 10 months ago (2015-01-28 20:51:29 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel/builds/29730)
5 years, 10 months ago (2015-01-28 22:25:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/865673003/20001
5 years, 10 months ago (2015-01-28 22:38:33 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 10 months ago (2015-01-28 23:20:38 UTC) #14
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6302d690c0b3aa762b92300564d9313876c6a2bf Cr-Commit-Position: refs/heads/master@{#313610}
5 years, 10 months ago (2015-01-28 23:21:48 UTC) #15
Bernhard Bauer
Wait, are you sure my patch was at fault here? It only excluded a test ...
5 years, 10 months ago (2015-01-28 23:40:12 UTC) #16
oshima
On 2015/01/28 23:40:12, Bernhard Bauer wrote: > Wait, are you sure my patch was at ...
5 years, 10 months ago (2015-01-29 01:24:46 UTC) #17
achaulk
5 years, 10 months ago (2015-01-29 17:29:50 UTC) #18
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:20001) has been created in
https://codereview.chromium.org/888653002/ by achaulk@chromium.org.

The reason for reverting is: This isn't the cause of the crash.

Powered by Google App Engine
This is Rietveld 408576698