Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 865603007: Remove unused and unimplemented abstract functions from GrRenderTarget (Closed)

Created:
5 years, 10 months ago by Kimmo Kinnunen
Modified:
5 years, 10 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove unused and unimplemented abstract functions from GrRenderTarget Remove unused and unimplemented abstract functions from GrRenderTarget. The functions might cause confusion later. BUG=skia:3388 Committed: https://skia.googlesource.com/skia/+/2340dcb02c683885707a24ed6ecd7732c29735dc

Patch Set 1 #

Patch Set 2 : add missing part #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -16 lines) Patch
M include/gpu/GrRenderTarget.h View 1 chunk +0 lines, -14 lines 0 comments Download
M src/gpu/gl/GrGLRenderTarget.h View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Kimmo Kinnunen
5 years, 10 months ago (2015-02-03 12:57:55 UTC) #2
bsalomon
lgtm
5 years, 10 months ago (2015-02-03 16:47:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/865603007/1
5 years, 10 months ago (2015-02-03 16:56:09 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot/builds/1859)
5 years, 10 months ago (2015-02-03 16:58:50 UTC) #7
Kimmo Kinnunen
oops, forgot the part where they were trivially implemented, but not used. This should not ...
5 years, 10 months ago (2015-02-04 06:13:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/865603007/20001
5 years, 10 months ago (2015-02-04 06:14:26 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 06:20:23 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/2340dcb02c683885707a24ed6ecd7732c29735dc

Powered by Google App Engine
This is Rietveld 408576698