Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 865603002: Use rtc_base instead of webrtc_base. (Closed)

Created:
5 years, 11 months ago by kjellander_chromium
Modified:
5 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use rtc_base instead of webrtc_base. The webrtc_base target is going away. Committed: https://crrev.com/d7ce058384dd92263b59836d11e6fde7950e3eb7 Cr-Commit-Position: refs/heads/master@{#312373}

Patch Set 1 #

Patch Set 2 : Added components/devtools_bridge.gyp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M components/devtools_bridge.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/libjingle/libjingle.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
kjellander_chromium
This should have been changed a while back. I'm planning to clean up WebRTC now, ...
5 years, 11 months ago (2015-01-21 12:18:07 UTC) #2
kjellander_chromium
+mnaganov for components/devtools_bridge.gyp
5 years, 11 months ago (2015-01-21 12:20:46 UTC) #4
kjellander_chromium
On 2015/01/21 12:20:46, kjellander wrote: > +mnaganov for components/devtools_bridge.gyp I realized the GN BUILD.gn files ...
5 years, 11 months ago (2015-01-21 12:29:07 UTC) #5
mnaganov (inactive)
lgtm
5 years, 11 months ago (2015-01-21 12:31:53 UTC) #6
perkj_chrome
On 2015/01/21 12:31:53, mnaganov (cr) wrote: > lgtm lgtm
5 years, 11 months ago (2015-01-21 12:43:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/865603002/20001
5 years, 11 months ago (2015-01-21 12:48:16 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-21 14:36:04 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-21 14:38:50 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d7ce058384dd92263b59836d11e6fde7950e3eb7
Cr-Commit-Position: refs/heads/master@{#312373}

Powered by Google App Engine
This is Rietveld 408576698