Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Side by Side Diff: content/browser/android/content_view_render_view.cc

Issue 865413002: Remove unnecessary LayerTreeBuildHelper from ContentViewRenderView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/android/content_view_render_view.h" 5 #include "content/browser/android/content_view_render_view.h"
6 6
7 #include "base/android/jni_android.h" 7 #include "base/android/jni_android.h"
8 #include "base/android/jni_string.h" 8 #include "base/android/jni_string.h"
9 #include "base/android/scoped_java_ref.h" 9 #include "base/android/scoped_java_ref.h"
10 #include "base/bind.h" 10 #include "base/bind.h"
11 #include "base/lazy_instance.h" 11 #include "base/lazy_instance.h"
12 #include "base/memory/scoped_ptr.h" 12 #include "base/memory/scoped_ptr.h"
13 #include "base/message_loop/message_loop.h" 13 #include "base/message_loop/message_loop.h"
14 #include "cc/layers/layer.h" 14 #include "cc/layers/layer.h"
15 #include "content/browser/android/content_view_core_impl.h" 15 #include "content/browser/android/content_view_core_impl.h"
16 #include "content/public/browser/android/compositor.h" 16 #include "content/public/browser/android/compositor.h"
17 #include "content/public/browser/android/content_view_layer_renderer.h" 17 #include "content/public/browser/android/content_view_layer_renderer.h"
18 #include "content/public/browser/android/layer_tree_build_helper.h"
19 #include "jni/ContentViewRenderView_jni.h" 18 #include "jni/ContentViewRenderView_jni.h"
20 #include "ui/gfx/android/java_bitmap.h" 19 #include "ui/gfx/android/java_bitmap.h"
21 #include "ui/gfx/geometry/size.h" 20 #include "ui/gfx/geometry/size.h"
22 21
23 #include <android/bitmap.h> 22 #include <android/bitmap.h>
24 #include <android/native_window_jni.h> 23 #include <android/native_window_jni.h>
25 24
26 using base::android::ScopedJavaLocalRef; 25 using base::android::ScopedJavaLocalRef;
27 26
28 namespace content { 27 namespace content {
29 28
30 namespace {
31
32 class LayerTreeBuildHelperImpl : public LayerTreeBuildHelper {
33 public:
34 LayerTreeBuildHelperImpl() {}
35 virtual ~LayerTreeBuildHelperImpl() {}
36
37 virtual scoped_refptr<cc::Layer> GetLayerTree(
38 scoped_refptr<cc::Layer> content_root_layer) override {
39 return content_root_layer;
40 }
41
42 private:
43 DISALLOW_COPY_AND_ASSIGN(LayerTreeBuildHelperImpl);
44 };
45
46 } // anonymous namespace
47
48 // static 29 // static
49 bool ContentViewRenderView::RegisterContentViewRenderView(JNIEnv* env) { 30 bool ContentViewRenderView::RegisterContentViewRenderView(JNIEnv* env) {
50 return RegisterNativesImpl(env); 31 return RegisterNativesImpl(env);
51 } 32 }
52 33
53 ContentViewRenderView::ContentViewRenderView(JNIEnv* env, 34 ContentViewRenderView::ContentViewRenderView(JNIEnv* env,
54 jobject obj, 35 jobject obj,
55 gfx::NativeWindow root_window) 36 gfx::NativeWindow root_window)
56 : layer_tree_build_helper_(new LayerTreeBuildHelperImpl()), 37 : root_window_(root_window), current_surface_format_(0) {
57 root_window_(root_window),
58 current_surface_format_(0) {
59 java_obj_.Reset(env, obj); 38 java_obj_.Reset(env, obj);
60 } 39 }
61 40
62 ContentViewRenderView::~ContentViewRenderView() { 41 ContentViewRenderView::~ContentViewRenderView() {
63 } 42 }
64 43
65 void ContentViewRenderView::SetLayerTreeBuildHelper(JNIEnv* env,
66 jobject obj,
67 jlong native_build_helper) {
68 CHECK(native_build_helper);
69
70 LayerTreeBuildHelper* build_helper =
71 reinterpret_cast<LayerTreeBuildHelper*>(native_build_helper);
72 layer_tree_build_helper_.reset(build_helper);
73 InitCompositor();
74 }
75 // static 44 // static
76 static jlong Init(JNIEnv* env, 45 static jlong Init(JNIEnv* env,
77 jobject obj, 46 jobject obj,
78 jlong native_root_window) { 47 jlong native_root_window) {
79 gfx::NativeWindow root_window = 48 gfx::NativeWindow root_window =
80 reinterpret_cast<gfx::NativeWindow>(native_root_window); 49 reinterpret_cast<gfx::NativeWindow>(native_root_window);
81 ContentViewRenderView* content_view_render_view = 50 ContentViewRenderView* content_view_render_view =
82 new ContentViewRenderView(env, obj, root_window); 51 new ContentViewRenderView(env, obj, root_window);
83 return reinterpret_cast<intptr_t>(content_view_render_view); 52 return reinterpret_cast<intptr_t>(content_view_render_view);
84 } 53 }
85 54
86 void ContentViewRenderView::Destroy(JNIEnv* env, jobject obj) { 55 void ContentViewRenderView::Destroy(JNIEnv* env, jobject obj) {
87 delete this; 56 delete this;
88 } 57 }
89 58
90 void ContentViewRenderView::SetCurrentContentViewCore( 59 void ContentViewRenderView::SetCurrentContentViewCore(
91 JNIEnv* env, jobject obj, jlong native_content_view_core) { 60 JNIEnv* env, jobject obj, jlong native_content_view_core) {
92 InitCompositor(); 61 InitCompositor();
93 ContentViewCoreImpl* content_view_core = 62 ContentViewCoreImpl* content_view_core =
94 reinterpret_cast<ContentViewCoreImpl*>(native_content_view_core); 63 reinterpret_cast<ContentViewCoreImpl*>(native_content_view_core);
95 compositor_->SetRootLayer(content_view_core 64 compositor_->SetRootLayer(content_view_core ? content_view_core->GetLayer()
96 ? layer_tree_build_helper_->GetLayerTree( 65 : scoped_refptr<cc::Layer>());
97 content_view_core->GetLayer())
98 : scoped_refptr<cc::Layer>());
99 } 66 }
100 67
101 void ContentViewRenderView::SurfaceCreated( 68 void ContentViewRenderView::SurfaceCreated(
102 JNIEnv* env, jobject obj) { 69 JNIEnv* env, jobject obj) {
103 current_surface_format_ = 0; 70 current_surface_format_ = 0;
104 InitCompositor(); 71 InitCompositor();
105 } 72 }
106 73
107 void ContentViewRenderView::SurfaceDestroyed(JNIEnv* env, jobject obj) { 74 void ContentViewRenderView::SurfaceDestroyed(JNIEnv* env, jobject obj) {
108 compositor_->SetSurface(NULL); 75 compositor_->SetSurface(NULL);
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
144 compositor_.reset(Compositor::Create(this, root_window_)); 111 compositor_.reset(Compositor::Create(this, root_window_));
145 } 112 }
146 113
147 jlong ContentViewRenderView::GetUIResourceProvider(JNIEnv* env, 114 jlong ContentViewRenderView::GetUIResourceProvider(JNIEnv* env,
148 jobject obj) { 115 jobject obj) {
149 if (!compositor_) 116 if (!compositor_)
150 return 0; 117 return 0;
151 return reinterpret_cast<intptr_t>(&compositor_->GetUIResourceProvider()); 118 return reinterpret_cast<intptr_t>(&compositor_->GetUIResourceProvider());
152 } 119 }
153 } // namespace content 120 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698